optimize: seata server startup mode support nacos yaml config ability #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
标题英文,以optimize: 开头 |
|
|
funky-eyes
requested changes
Sep 3, 2021
config/seata-config-nacos/src/main/java/io/seata/config/nacos/NacosConfiguration.java
Outdated
Show resolved
Hide resolved
|
其它几个支持properties的配置中心请一起进行适配 |
x-shadow-man
changed the title
ok. done. |
英文= - |
x-shadow-man
changed the title
sorry, forget to change local github account! x-shadow-man is the right account. |
funky-eyes
reviewed
Sep 6, 2021
config/seata-config-core/src/main/java/io/seata/config/processor/ProcessorYaml.java
Outdated
Show resolved
Hide resolved
config/seata-config-nacos/src/main/java/io/seata/config/nacos/NacosConfiguration.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Sep 8, 2021
config/seata-config-core/src/main/java/io/seata/config/processor/ProcessorYaml.java
Outdated
Show resolved
Hide resolved
config/seata-config-zk/src/main/java/io/seata/config/zk/ZookeeperConfiguration.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Sep 11, 2021
...ore/src/main/java/io/seata/spring/boot/autoconfigure/properties/config/ConfigProperties.java
Outdated
Show resolved
Hide resolved
config/seata-config-nacos/src/main/java/io/seata/config/nacos/NacosConfiguration.java
Outdated
Show resolved
Hide resolved
config/seata-config-nacos/src/main/java/io/seata/config/nacos/NacosConfiguration.java
Outdated
Show resolved
Hide resolved
config/seata-config-core/src/main/java/io/seata/config/processor/ProcessorYaml.java
Show resolved
Hide resolved
funky-eyes
approved these changes
Sep 14, 2021
UmmizzZ
pushed a commit
to UmmizzZ/seata
that referenced
this pull request
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
解决 issue # 3829: seata server端读取nacos配置问题
Ⅱ. Does this pull request fix one issue?
fixes: #3829
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews