Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize client channel alive check #4013

Merged
merged 3 commits into from
Sep 14, 2021
Merged

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Sep 12, 2021

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #4002

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 1.5.0 milestone Sep 12, 2021
@funky-eyes funky-eyes requested review from lj2018110133 and slievrly and removed request for lj2018110133 September 12, 2021 14:03
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2021

Codecov Report

Merging #4013 (21d7dae) into develop (f028831) will increase coverage by 0.13%.
The diff coverage is 43.15%.

❗ Current head 21d7dae differs from pull request most recent head b30c3bf. Consider uploading reports for the commit b30c3bf to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4013      +/-   ##
=============================================
+ Coverage      49.34%   49.47%   +0.13%     
- Complexity      3721     3724       +3     
=============================================
  Files            692      692              
  Lines          23419    23404      -15     
  Branches        2902     2903       +1     
=============================================
+ Hits           11555    11579      +24     
+ Misses         10701    10663      -38     
+ Partials        1163     1162       -1     
Impacted Files Coverage Δ
...io/seata/core/rpc/netty/AbstractNettyRemoting.java 14.28% <0.00%> (ø)
...a/io/seata/discovery/registry/RegistryService.java 0.00% <0.00%> (ø)
...source/exec/mysql/MySQLInsertOrUpdateExecutor.java 31.42% <ø> (-0.04%) ⬇️
...urce/exec/postgresql/PostgresqlInsertExecutor.java 43.75% <0.00%> (ø)
...seata/rm/datasource/undo/AbstractUndoExecutor.java 66.90% <0.00%> (ø)
...ta/spring/boot/autoconfigure/StarterConstants.java 0.00% <ø> (ø)
...figure/properties/registry/RegistryProperties.java 37.50% <0.00%> (-22.50%) ⬇️
.../src/main/java/io/seata/server/env/PortHelper.java 0.00% <0.00%> (ø)
...ure/properties/server/store/StoreDBProperties.java 28.07% <25.00%> (-0.24%) ⬇️
server/src/main/java/io/seata/server/Server.java 75.00% <33.33%> (-5.00%) ⬇️
... and 12 more

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title optimize: channel alive check optimize: optimize client channel alive check Sep 14, 2021
@slievrly slievrly merged commit 0d2862e into apache:develop Sep 14, 2021
UmmizzZ pushed a commit to UmmizzZ/seata that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service address exploration of the registry center
3 participants