Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: remove dubbo PRC communication xid transmission. #4023

Merged
merged 8 commits into from
Sep 18, 2021

Conversation

springlayer
Copy link
Contributor

@springlayer springlayer commented Sep 17, 2021

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #3844

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #4023 (f6b407a) into develop (b71ba74) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4023      +/-   ##
=============================================
+ Coverage      49.95%   49.97%   +0.01%     
- Complexity      3770     3771       +1     
=============================================
  Files            698      698              
  Lines          23490    23498       +8     
  Branches        2908     2908              
=============================================
+ Hits           11734    11742       +8     
  Misses         10576    10576              
  Partials        1180     1180              
Impacted Files Coverage Δ
...baba/AlibabaDubboTransactionPropagationFilter.java 56.52% <100.00%> (+4.14%) ⬆️
...dubbo/ApacheDubboTransactionPropagationFilter.java 59.09% <100.00%> (+4.09%) ⬆️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone Sep 18, 2021
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/integration integration module labels Sep 18, 2021
@funky-eyes funky-eyes merged commit 03c9006 into apache:develop Sep 18, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

UmmizzZ pushed a commit to UmmizzZ/seata that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/integration integration module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

事务结束时没有清空RpcContext中的事务ID
4 participants