-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix ApplicationContext already closed problem when Seata server using ShutdownHook to destroy. #4032
Merged
funky-eyes
merged 5 commits into
apache:develop
from
Pinocchio2018:develop_fix_server_shutdown_problem
Sep 26, 2021
Merged
bugfix: fix ApplicationContext already closed problem when Seata server using ShutdownHook to destroy. #4032
funky-eyes
merged 5 commits into
apache:develop
from
Pinocchio2018:develop_fix_server_shutdown_problem
Sep 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinocchio2018
force-pushed
the
develop_fix_server_shutdown_problem
branch
from
September 22, 2021 07:38
eeb08ca
to
79149e3
Compare
funky-eyes
reviewed
Sep 22, 2021
funky-eyes
reviewed
Sep 22, 2021
Pinocchio2018
force-pushed
the
develop_fix_server_shutdown_problem
branch
2 times, most recently
from
September 22, 2021 08:31
b079858
to
e0fa703
Compare
Pinocchio2018
changed the title
bugfix: let ServerRunner do destroy instead ShutdownHook. (#4028)
bugfix: fix ApplicationContext already closed problem when Seata server using ShutdownHook to destroy.
Sep 22, 2021
Pinocchio2018
force-pushed
the
develop_fix_server_shutdown_problem
branch
from
September 22, 2021 09:08
e0fa703
to
e2c62ef
Compare
funky-eyes
added
first-time contributor
first-time contributor
module/server
server module
type: bug
Category issues or prs related to bug.
labels
Sep 22, 2021
Pinocchio2018
force-pushed
the
develop_fix_server_shutdown_problem
branch
from
September 22, 2021 09:58
e2c62ef
to
6cc27fd
Compare
funky-eyes
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…er using ShutdownHook to destroy.
Pinocchio2018
force-pushed
the
develop_fix_server_shutdown_problem
branch
from
September 26, 2021 07:50
5770abd
to
c5ab0f8
Compare
…_shutdown_problem # Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md # seata-spring-autoconfigure/seata-spring-autoconfigure-core/src/test/java/io/seata/spring/boot/autoconfigure/BasePropertiesTest.java
Codecov Report
@@ Coverage Diff @@
## develop #4032 +/- ##
==========================================
Coverage 49.91% 49.91%
- Complexity 3766 3767 +1
==========================================
Files 698 698
Lines 23498 23509 +11
Branches 2907 2910 +3
==========================================
+ Hits 11729 11735 +6
- Misses 10589 10593 +4
- Partials 1180 1181 +1
|
slievrly
reviewed
Sep 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
first-time contributor
first-time contributor
module/server
server module
type: bug
Category issues or prs related to bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
in develop version,when ShutdownHook doing destroyAll,an Exception happened because ApplicationContext is already closed
Ⅱ. Does this pull request fix one issue?
fix #4028
Ⅲ. Why don't you add test cases (unit test/integration test)?
I don't know how to write one in this problem.
Ⅳ. Describe how to verify it
ServerApplication
in debug modeⅤ. Special notes for reviews