Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize Nacos, Consul, Zookeeper and Etcd3 configuration J… #4034

Merged

Conversation

Pinocchio2018
Copy link
Contributor

…unit test Class

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize Nacos, Consul, Zookeeper and Etcd3 configuration Junit test Class

Ⅱ. Does this pull request fix one issue?

no。

Ⅲ. Why don't you add test cases (unit test/integration test)?

because I 'm fixing one test cases

Ⅳ. Describe how to verify it

do Junit test under directory 'seata\seata-spring-autoconfigure\seata-spring-autoconfigure-core\src\test\java'

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 1.5.0 milestone Sep 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2021

Codecov Report

Merging #4034 (7f32950) into develop (b71ba74) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4034      +/-   ##
=============================================
- Coverage      49.95%   49.91%   -0.04%     
+ Complexity      3770     3765       -5     
=============================================
  Files            698      698              
  Lines          23490    23498       +8     
  Branches        2908     2908              
=============================================
- Hits           11734    11730       -4     
- Misses         10576    10589      +13     
+ Partials        1180     1179       -1     
Impacted Files Coverage Δ
...main/java/io/seata/common/holder/ObjectHolder.java 50.00% <0.00%> (ø)
...ration/http/TransactionPropagationInterceptor.java 42.85% <0.00%> (ø)
...in/java/io/seata/integration/http/XidResource.java 30.76% <0.00%> (ø)
...baba/AlibabaDubboTransactionPropagationFilter.java 56.52% <100.00%> (+4.14%) ⬆️
...dubbo/ApacheDubboTransactionPropagationFilter.java 59.09% <100.00%> (+4.09%) ⬆️
...ver/storage/redis/session/RedisSessionManager.java 29.82% <0.00%> (-10.53%) ⬇️
...in/java/io/seata/server/session/SessionHolder.java 51.49% <0.00%> (-7.47%) ⬇️
...io/seata/core/rpc/netty/AbstractNettyRemoting.java 12.98% <0.00%> (-1.30%) ⬇️
...tasource/sql/struct/cache/MysqlTableMetaCache.java 80.45% <0.00%> (-1.15%) ⬇️
...rage/redis/store/RedisTransactionStoreManager.java 64.16% <0.00%> (-0.84%) ⬇️
... and 4 more

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pr登记一下

@jsbxyyx
Copy link
Member

jsbxyyx commented Sep 26, 2021

add tearDown?

@funky-eyes funky-eyes merged commit 8fd705b into apache:develop Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants