Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: NetUtil#getLocalAddress0 #4055

Merged
merged 4 commits into from
Oct 9, 2021
Merged

Conversation

lvekee
Copy link
Contributor

@lvekee lvekee commented Oct 7, 2021

Ⅰ. Describe what this PR did

optimize NetUtil#getLocalAddress0

Ⅱ. Does this pull request fix one issue?

fixes #4054.

@lvekee lvekee changed the title optimize NetUtil#getLocalAddress0 optimize:NetUtil#getLocalAddress0 Oct 7, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #4055 (bd6a30e) into develop (b0dab9c) will decrease coverage by 0.38%.
The diff coverage is 20.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4055      +/-   ##
=============================================
- Coverage      49.81%   49.42%   -0.39%     
+ Complexity      3774     3749      -25     
=============================================
  Files            700      700              
  Lines          23567    23571       +4     
  Branches        2911     2912       +1     
=============================================
- Hits           11740    11651      -89     
- Misses         10649    10733      +84     
- Partials        1178     1187       +9     
Impacted Files Coverage Δ
...on/src/main/java/io/seata/common/util/NetUtil.java 56.97% <20.00%> (-8.88%) ⬇️
...java/io/seata/server/metrics/MeterIdConstants.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/io/seata/server/metrics/MetricsSubscriber.java 18.84% <0.00%> (-53.63%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 48.92% <0.00%> (-5.38%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 79.56% <0.00%> (-3.92%) ⬇️
...io/seata/core/rpc/netty/AbstractNettyRemoting.java 12.98% <0.00%> (-1.30%) ⬇️
...tasource/sql/struct/cache/MysqlTableMetaCache.java 80.45% <0.00%> (-1.15%) ⬇️
...torage/file/store/FileTransactionStoreManager.java 56.77% <0.00%> (ø)
... and 2 more

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title optimize:NetUtil#getLocalAddress0 optimize: NetUtil#getLocalAddress0 Oct 9, 2021
@slievrly slievrly merged commit 9d5ff40 into apache:develop Oct 9, 2021
@wangliang181230 wangliang181230 added this to the 1.5.0 milestone Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimize NetUtil#getLocalAddress0
5 participants