Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: optimize the DurationUtil #4056

Merged
merged 10 commits into from
Oct 21, 2021
Merged

optimize: optimize the DurationUtil #4056

merged 10 commits into from
Oct 21, 2021

Conversation

lvekee
Copy link
Contributor

@lvekee lvekee commented Oct 8, 2021

Ⅰ. Describe what this PR did

optimize: DurationUtil

Ⅱ. Does this pull request fix one issue?

fixes #4048.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2021 •
edited

Codecov Report

Merging #4056 (abcae35) into develop (9d5ff40) will decrease coverage by 0.03%.
The diff coverage is 75.86%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4056      +/-   ##
=============================================
- Coverage      49.44%   49.41%   -0.04%     
+ Complexity      3750     3745       -5     
=============================================
  Files            700      700              
  Lines          23571    23578       +7     
  Branches        2912     2907       -5     
=============================================
- Hits           11654    11650       -4     
- Misses         10731    10739       +8     
- Partials        1186     1189       +3
Impacted Files Coverage Δ
...e/src/main/java/io/seata/config/Configuration.java 42.85% <ø> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 48.92% <0.00%> (ø)
...in/java/io/seata/rm/tcc/config/TCCFenceConfig.java 0.00% <0.00%> (ø)
...c/main/java/io/seata/common/util/DurationUtil.java 83.33% <83.33%> (-16.67%) ⬇️
...oconfigure/properties/server/ServerProperties.java 29.16% <100.00%> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
...erver/storage/file/session/FileSessionManager.java 48.90% <0.00%> (-2.92%) ⬇️
...io/seata/core/rpc/netty/AbstractNettyRemoting.java 14.28% <0.00%> (+1.29%) ⬆️

@lvekee
Merge branch 'develop' into optimizeDurationUtil
b382728 
# Conflicts:
#	changes/1.5.0.md
#	changes/en-us/1.5.0.md
lightClouds917
lightClouds917 approved these changes Oct 9, 2021
View reviewed changes
Copy link
Contributor

@lightClouds917 lightClouds917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caohdgege
Copy link
Contributor

lALPDgtYygQG3-LMrc0Dzg_974_173
这几个地方统一一下吧

caohdgege
caohdgege approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caohdgege
caohdgege reviewed Oct 20, 2021
View reviewed changes
changes/en-us/1.5.0.md Outdated Show resolved Hide resolved
@lvekee lvekee changed the title optimize: DurationUtil optimize: optimize the DurationUtil Oct 21, 2021
@caohdgege caohdgege added this to the 1.5.0 milestone Oct 21, 2021
@caohdgege caohdgege merged commit 1775022 into apache:develop Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caohdgege caohdgege caohdgege approved these changes

@lightClouds917 lightClouds917 lightClouds917 approved these changes

Assignees
No one assigned
Labels
type: optimize
Projects
None yet
Milestone
1.5.0 (1.5.1)
Development

Successfully merging this pull request may close these issues.

optimize DurationUtil
4 participants
@lvekee @codecov-commenter @caohdgege @lightClouds917