optimize: optimize AbstractLockManager#collectRowLocks logic #4103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
approved these changes
Oct 29, 2021
funky-eyes
changed the title
|
英文版直接按照标题填写登记即可,中文版可详细描述,比如 减少无需竞争锁时的内存占用 |
|
hello,欢迎你成为seata的贡献者,请将你的钉钉号发送至 364176773@qq.com 邮箱,我将会邀请你加入seata的贡献者队伍中 |
funky-eyes
added
module/server
caohdgege
reviewed
Oct 29, 2021
changes/en-us/1.5.0.md
Outdated
| @@ -126,7 +126,7 @@ | |||
| - [[#4034](https://github.com/seata/seata/pull/4034)] optimize Nacos, Consul, Zookeeper and Etcd3 configuration Junit test Class | |||
| - [[#4055](https://github.com/seata/seata/pull/4055)] optimize NetUtil#getLocalAddress0 | |||
| - [[#4056](https://github.com/seata/seata/pull/4056)] optimize the DurationUtil | |||
|
|
|||
| - [[#4101](https://github.com/seata/seata/pull/4103)] optimize: optimize AbstractLockManager#collectRowLocks logic | |||
changes/1.5.0.md
Outdated
| @@ -127,6 +127,7 @@ Seata 是一款开源的分布式事务解决方案，提供高性能和简单 | |||
| - [[#4034](https://github.com/seata/seata/pull/4034)] 优化“优化 Nacos、Consul、Zookeeper、Etcd3 配置（#4019）”的单元测试类 | |||
| - [[#4055](https://github.com/seata/seata/pull/4055)] 优化NetUtil的getLocalAddress0方法 | |||
| - [[#4056](https://github.com/seata/seata/pull/4056)] 优化 DurationUtil | |||
| - [[#4101](https://github.com/seata/seata/pull/4103)] 减少分支事务注册无需竞争锁时的内存占用 | |||
| @@ -161,8 +162,7 @@ Seata 是一款开源的分布式事务解决方案，提供高性能和简单 | |||
| - [dmego](https://github.com/dmego) | |||
| - [zhixing](https://github.com/chenlei3641) | |||
| - [siyu](https://github.com/Pinocchio2018) | |||
|
|
|||
|
|
|||
| - [xujj](https://github.com/XBNGit) | |||
| @@ -160,7 +160,7 @@ | |||
| - [dmego](https://github.com/dmego) | |||
| - [zhixing](https://github.com/chenlei3641) | |||
| - [siyu](https://github.com/Pinocchio2018) | |||
|
|
|||
| - [xujj](https://github.com/XBNGit) | |||
Codecov Report
@@ Coverage Diff @@
## develop #4103 +/- ##
==========================================
Coverage 49.41% 49.42%
- Complexity 3751 3753 +2
==========================================
Files 700 700
Lines 23614 23613 -1
Branches 2915 2914 -1
==========================================
+ Hits 11670 11671 +1
Misses 10751 10751
+ Partials 1193 1191 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Optimization: confirm that the list is created only when necessary to help GC, issue #4101
Ⅱ. Does this pull request fix one issue?
fixes #4101
Ⅲ. Why don't you add test cases (unit test/integration test)?
just the optimization of GC
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews