optimize: support default configuration of tx-service-group #4144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Nov 18, 2021
core/src/main/java/io/seata/core/rpc/netty/NettyClientChannelManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/NettyClientChannelManager.java
Outdated
Show resolved
Hide resolved
|
/home/runner/work/seata/seata/spring/src/main/java/io/seata/spring/annotation/GlobalTransactionScanner.java:67:15: Unused import - io.seata.common.DefaultValues.DEFAULT_TX_GROUP. [UnusedImports] |
|
|
tanzzj
commented
Nov 18, 2021
| "please change your default configuration as soon as possible " + | ||
| "and we don't recommend you to use default tx-service-group's value provided by seata", | ||
| DEFAULT_TX_GROUP_OLD, DEFAULT_TX_GROUP); | ||
| } |
There was a problem hiding this comment.
移动到scanner避免20s重复打日志
tanzzj
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #4144 +/- ##
=============================================
+ Coverage 49.46% 49.76% +0.30%
- Complexity 3757 3764 +7
=============================================
Files 700 700
Lines 23608 23608
Branches 2913 2913
=============================================
+ Hits 11678 11749 +71
+ Misses 10738 10663 -75
- Partials 1192 1196 +4
|
funky-eyes
reviewed
Nov 19, 2021
server/src/test/java/io/seata/server/session/GlobalSessionTest.java
Outdated
Show resolved
Hide resolved
funky-eyes
added
module/config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
支持默认的事物分组配置，使事务分组配置成为进阶配置，入门和单集群模式下不需要再配置事务分组，降低入门门槛;
将默认事务分组value由 my_test_tx_group 修改为 default_tx_group, 避免歧义;
seata 1.5先向下兼容 my_test_tx_group，seata 2.0 去掉my_test_tx_group，全局替换为default_tx_group，并且增加了warn级别的logger日志提醒用户及时替换默认value;
将单测中写死的事务分组名修改为静态全局变量;
修改一些代码规范问题
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews