Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the logback can't load the RPC_PORT #4158

Merged
merged 7 commits into from
Nov 30, 2021

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Nov 29, 2021

bugfix: fix the logback can't load the RPC_PORT

fixes #4159

@funky-eyes funky-eyes added this to the 1.5.0 milestone Nov 29, 2021
@funky-eyes funky-eyes added module/server server module type: optimize type: bug Category issues or prs related to bug. and removed type: optimize labels Nov 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2021

Codecov Report

Merging #4158 (ff2a70e) into develop (87d773f) will decrease coverage by 0.00%.
The diff coverage is 52.94%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4158      +/-   ##
=============================================
- Coverage      49.76%   49.75%   -0.01%     
- Complexity      3766     3767       +1     
=============================================
  Files            700      700              
  Lines          23621    23624       +3     
  Branches        2914     2917       +3     
=============================================
+ Hits           11754    11755       +1     
+ Misses         10671    10669       -2     
- Partials        1196     1200       +4     
Impacted Files Coverage Δ
...ava/io/seata/server/ServerApplicationListener.java 47.36% <52.94%> (ø)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
test all the follow cases pass.

-p 8091 -m file

-Dserver.servicePort=8091

EXPORT SEATA_PORT=8091

yml

@funky-eyes funky-eyes merged commit 2639ec8 into apache:develop Nov 30, 2021
@wangliang181230 wangliang181230 deleted the bugfix/logging-file branch November 30, 2021 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC_PORT IS UNDEFINED
4 participants