Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve CONTRIBUTING docs #4163

Merged
merged 4 commits into from
Dec 1, 2021
Merged

Conversation

iportman
Copy link
Contributor

@iportman iportman commented Dec 1, 2021

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Improve CONTRIBUTING docs

  1. Define format of the embedded script
  2. Add embedded script for 'git config'
  3. Improve case for 'github'

Ⅱ. Does this pull request fix one issue?

NO, just improve docs.

Ⅲ. Why don't you add test cases (unit test/integration test)?

Unnecessary for docs.

Ⅳ. Describe how to verify it

See the change via any markdown reader

Ⅴ. Special notes for reviews

…. Add embedded script for 'git config' , 3. Improve case for 'github'
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Please register the author and PR information in two 1.5.0.md files under the Changes folder

@funky-eyes funky-eyes changed the title Improve CONTRIBUTING docs docs: improve CONTRIBUTING docs Dec 1, 2021
@funky-eyes funky-eyes added this to the 1.5.0 milestone Dec 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #4163 (d189a4c) into develop (f901e08) will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4163      +/-   ##
=============================================
- Coverage      49.75%   49.42%   -0.34%     
+ Complexity      3767     3759       -8     
=============================================
  Files            700      700              
  Lines          23626    23626              
  Branches        2917     2918       +1     
=============================================
- Hits           11755    11677      -78     
- Misses         10671    10756      +85     
+ Partials        1200     1193       -7     
Impacted Files Coverage Δ
...java/io/seata/server/metrics/MeterIdConstants.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/io/seata/server/metrics/MetricsSubscriber.java 18.84% <0.00%> (-53.63%) ⬇️
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (-7.70%) ⬇️
...erver/storage/file/session/FileSessionManager.java 51.82% <0.00%> (-5.11%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 47.84% <0.00%> (-1.08%) ⬇️
...torage/file/store/FileTransactionStoreManager.java 56.12% <0.00%> (-0.65%) ⬇️
...rage/redis/store/RedisTransactionStoreManager.java 64.16% <0.00%> (-0.42%) ⬇️
...tasource/sql/struct/cache/MysqlTableMetaCache.java 81.60% <0.00%> (+1.14%) ⬆️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit c60cb5e into apache:develop Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants