Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix StringUtils.toString(obj) throw ClassCastException when the obj is primitive data array #4165

Merged

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Dec 2, 2021

bugfix: fix StringUtils.toString(obj) throw ClassCastException when the obj is primitive data array.
BUG修复:修复 StringUtils.toString(obj) 当obj是基本数据数组时,抛出ClassCastException的问题。

@wangliang181230 wangliang181230 changed the title bugfix: fix StringUtils.toString(obj) throw ClassCastException when the obj is primitive data array bugfix: fix StringUtils.toString(obj) throw ClassCastException when the obj is primitive data array Dec 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #4165 (c12e545) into develop (c86f7ef) will decrease coverage by 0.00%.
The diff coverage is 45.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4165      +/-   ##
=============================================
- Coverage      49.40%   49.39%   -0.01%     
- Complexity      3759     3765       +6     
=============================================
  Files            700      700              
  Lines          23637    23656      +19     
  Branches        2918     2923       +5     
=============================================
+ Hits           11677    11685       +8     
- Misses         10767    10772       +5     
- Partials        1193     1199       +6     
Impacted Files Coverage Δ
...src/main/java/io/seata/common/util/ArrayUtils.java 55.88% <42.10%> (-17.46%) ⬇️
...rc/main/java/io/seata/common/util/StringUtils.java 33.18% <100.00%> (ø)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added the module/common common module label Dec 2, 2021
@funky-eyes funky-eyes added this to the 1.5.0 milestone Dec 2, 2021
@funky-eyes funky-eyes added the type: bug Category issues or prs related to bug. label Dec 2, 2021
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 57789c2 into apache:develop Dec 2, 2021
@wangliang181230 wangliang181230 deleted the bugfix/fix-StringUtils-toString branch December 2, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/common common module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants