optimize: use expire key instead hash when using redis as registry center #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinocchio2018
force-pushed
the
develop_issue_4100
branch
2 times, most recently
from
7d17f16
to
161f7ca
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4176 +/- ##
=============================================
- Coverage 48.55% 48.53% -0.03%
Complexity 3791 3791
=============================================
Files 724 724
Lines 24236 24239 +3
Branches 2970 2971 +1
=============================================
- Hits 11768 11764 -4
- Misses 11229 11232 +3
- Partials 1239 1243 +4
|
slievrly
reviewed
Dec 8, 2021
...iscovery-redis/src/main/java/io/seata/discovery/registry/redis/RedisRegistryServiceImpl.java
Outdated
Show resolved
Hide resolved
|
The scheduled task renew triggers pub / sub every time, even if the serverlist is not changed |
@slievrly Do you mean that we can optimize the logic? we update the And, you remind me that there is another problem after I use string key instead hash. |
|
I want to add another |
Pinocchio2018
force-pushed
the
develop_issue_4100
branch
from
7ca43b1
to
6993106
Compare
Pinocchio2018
force-pushed
the
develop_issue_4100
branch
from
6993106
to
abe0717
Compare
…/seata into develop � Conflicts: � discovery/seata-discovery-redis/src/main/java/io/seata/discovery/registry/redis/RedisRegistryServiceImpl.java
|
I add some code in my local version of seata public class RedisRegistryServiceImpl implements RegistryService<RedisListener> {
List<InetSocketAddress> lookupByCluster(String clusterName) {
// ......
Set<InetSocketAddress> addrSet = CLUSTER_ADDRESS_MAP.getOrDefault(clusterName, Collections.emptySet());
LOGGER.info("返回的addrSet是:[{}]", addrSet);
return new ArrayList<>(addrSet);
}
private void updateClusterAddressMap(Jedis jedis, String redisRegistryKey) {
// ......
if (!newAddressSet.equals(CLUSTER_ADDRESS_MAP.get(clusterName))) {
LOGGER.info("update map :[{}] --> [{}]", CLUSTER_ADDRESS_MAP.get(clusterName), newAddressSet);
CLUSTER_ADDRESS_MAP.put(clusterName, newAddressSet);
}
}
}this is what I see on client side |
funky-eyes
reviewed
Dec 17, 2021
...iscovery-redis/src/main/java/io/seata/discovery/registry/redis/RedisRegistryServiceImpl.java
Outdated
Show resolved
Hide resolved
Pinocchio2018
force-pushed
the
develop_issue_4100
branch
from
506a138
to
173b3e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
use expire key instead hash when using redis as registry cente.
hash version:
expire String key version:
the redis registry key live 5 seconds, the heart-beat thread pool will auto refresh key every 2 seconds
Ⅱ. Does this pull request fix one issue?
fixes #4100
Ⅲ. Why don't you add test cases (unit test/integration test)?
I may need a sample to write unit test.
I 've tested with seata-samples
Ⅳ. Describe how to verify it
test with seata-samples
check redis
Ⅴ. Special notes for reviews