Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the kafka-appender.xml and logstash-appender.xml #4189

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Dec 10, 2021

bugfix: fix the kafka-appender.xml and logstash-appender.xml
BUG修复:kafka-appender.xmllogstash-appender.xml 两个配置文件中${}表达式后面的默认值前少了横杆

PR #3760 提交后,导致的BUG。

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2021

Codecov Report

Merging #4189 (0f2d6a3) into develop (945b899) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4189   +/-   ##
==========================================
  Coverage      49.08%   49.09%           
  Complexity      3773     3773           
==========================================
  Files            719      719           
  Lines          23948    23948           
  Branches        2925     2926    +1     
==========================================
+ Hits           11755    11757    +2     
  Misses         10989    10989           
+ Partials        1204     1202    -2     
Impacted Files Coverage Δ
...in/java/io/seata/server/session/GlobalSession.java 80.00% <0.00%> (+0.43%) ⬆️
...o/seata/server/coordinator/DefaultCoordinator.java 48.38% <0.00%> (+0.53%) ⬆️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added module/server server module type: bug Category issues or prs related to bug. labels Dec 14, 2021
@funky-eyes funky-eyes added this to the 1.5.0 milestone Dec 14, 2021
@wangliang181230 wangliang181230 merged commit caa8443 into apache:develop Dec 15, 2021
@wangliang181230 wangliang181230 deleted the bugfix/kafka-and-logstash-appender branch December 15, 2021 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants