-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: support rpc timeout can be customized. #4191
optimize: support rpc timeout can be customized. #4191
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4191 +/- ##
=============================================
- Coverage 49.37% 49.36% -0.02%
- Complexity 3763 3766 +3
=============================================
Files 700 701 +1
Lines 23664 23685 +21
Branches 2925 2924 -1
=============================================
+ Hits 11685 11692 +7
- Misses 10780 10795 +15
+ Partials 1199 1198 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 请登记pr信息至changes文件夹1.5.0.md
done. |
@@ -195,6 +195,11 @@ public boolean isEnableClientBatchSendRequest() { | |||
DefaultValues.DEFAULT_ENABLE_TM_CLIENT_BATCH_SEND_REQUEST); | |||
} | |||
|
|||
@Override | |||
public long getRpcRequestTimeout() { | |||
return NettyClientConfig.getRpcRmRequestTimeout(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
#4190
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews