Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix rpc tm request timeout. #4199

Merged
merged 2 commits into from
Dec 13, 2021

Conversation

objcoding
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #4199 (d104bde) into develop (4e2b199) will increase coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4199      +/-   ##
=============================================
+ Coverage      49.00%   49.08%   +0.08%     
+ Complexity      3772     3771       -1     
=============================================
  Files            719      719              
  Lines          23920    23948      +28     
  Branches        2875     2926      +51     
=============================================
+ Hits           11721    11755      +34     
- Misses         10977    10989      +12     
+ Partials        1222     1204      -18     
Impacted Files Coverage Δ
...io/seata/core/rpc/netty/TmNettyRemotingClient.java 55.68% <0.00%> (ø)
...dubbo/ApacheDubboTransactionPropagationFilter.java 59.09% <0.00%> (-1.38%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 79.56% <0.00%> (-1.33%) ⬇️
...baba/AlibabaDubboTransactionPropagationFilter.java 56.52% <0.00%> (-1.26%) ⬇️
...rage/redis/store/RedisTransactionStoreManager.java 64.58% <0.00%> (-0.55%) ⬇️
...a/io/seata/rm/datasource/xa/ResourceManagerXA.java 13.88% <0.00%> (-0.40%) ⬇️
...java/io/seata/spring/tcc/TccActionInterceptor.java 13.72% <0.00%> (-0.28%) ⬇️
...o/seata/server/storage/redis/lock/RedisLocker.java 44.84% <0.00%> (-0.28%) ⬇️
...ta/core/rpc/netty/AbstractNettyRemotingClient.java 18.44% <0.00%> (-0.19%) ⬇️
...n/java/io/seata/rm/datasource/ConnectionProxy.java 25.69% <0.00%> (-0.18%) ⬇️
... and 29 more

@funky-eyes funky-eyes added this to the 1.5.0 milestone Dec 13, 2021
@funky-eyes funky-eyes added module/core core module type: bug Category issues or prs related to bug. labels Dec 13, 2021
@funky-eyes funky-eyes merged commit 945b899 into apache:develop Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/core core module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants