-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix code for "sessionMode" not execute problem #4213
bugfix: fix code for "sessionMode" not execute problem #4213
Conversation
fc2cf26
to
e6bb3b4
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4213 +/- ##
=============================================
- Coverage 49.10% 49.08% -0.03%
+ Complexity 3774 3772 -2
=============================================
Files 719 719
Lines 23948 23948
Branches 2926 2926
=============================================
- Hits 11760 11755 -5
- Misses 10987 10989 +2
- Partials 1201 1204 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fix some code for "sessionMode" not execute problem.
if I config service-port ,
the following code will not execute
Ⅱ. Does this pull request fix one issue?
no
Ⅲ. Why don't you add test cases (unit test/integration test)?
I don't know how to do it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews