Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix code for "sessionMode" not execute problem #4213

Conversation

Pinocchio2018
Copy link
Contributor

@Pinocchio2018 Pinocchio2018 commented Dec 17, 2021

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix some code for "sessionMode" not execute problem.

if I config service-port ,

 server:
    service-port: 8091

the following code will not execute

        // Load by priority
        System.setProperty("sessionMode",
                environment.getProperty(SERVER_STORE_SESSION_MODE, environmentPreparedEvent.getEnvironment().getProperty(SERVER_STORE_MODE, "file")));
        System.setProperty("lockMode",
                environment.getProperty(SERVER_STORE_LOCK_MODE, environmentPreparedEvent.getEnvironment().getProperty(SERVER_STORE_MODE, "file")));

Ⅱ. Does this pull request fix one issue?

no

Ⅲ. Why don't you add test cases (unit test/integration test)?

I don't know how to do it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Pinocchio2018 Pinocchio2018 force-pushed the develop_fix_sessionMode_startup_problem branch from fc2cf26 to e6bb3b4 Compare December 17, 2021 01:37
@Pinocchio2018
Copy link
Contributor Author

image

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #4213 (e6bb3b4) into develop (caa8443) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4213      +/-   ##
=============================================
- Coverage      49.10%   49.08%   -0.03%     
+ Complexity      3774     3772       -2     
=============================================
  Files            719      719              
  Lines          23948    23948              
  Branches        2926     2926              
=============================================
- Hits           11760    11755       -5     
- Misses         10987    10989       +2     
- Partials        1201     1204       +3     
Impacted Files Coverage Δ
...ava/io/seata/server/ServerApplicationListener.java 52.38% <100.00%> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 47.84% <0.00%> (-0.54%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 79.56% <0.00%> (-0.44%) ⬇️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lightClouds917 lightClouds917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone Dec 17, 2021
@funky-eyes funky-eyes added module/server server module type: bug Category issues or prs related to bug. labels Dec 17, 2021
@lightClouds917 lightClouds917 merged commit 8590bbf into apache:develop Dec 17, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants