-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: client check whether undolog table exist before cleaning undolog #4216
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4216 +/- ##
=============================================
+ Coverage 48.98% 49.03% +0.04%
- Complexity 3772 3780 +8
=============================================
Files 720 720
Lines 24001 24031 +30
Branches 2927 2931 +4
=============================================
+ Hits 11758 11783 +25
+ Misses 11040 11038 -2
- Partials 1203 1210 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
补充一下md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
when RM receive UndoLogDeleteRequest(send by TC), if user does not use AT mode at all(which mean their database does not have undo_log table), exception would occur(such as undo_log table doesn't existed~) and logger will print error info(which scares user~). Here, we check whether undo_log table exist before trying to delete undolog.