Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: client check whether undolog table exist before cleaning undolog #4216

Merged
merged 6 commits into from
Dec 25, 2021

Conversation

selfishlover
Copy link
Contributor

Ⅰ. Describe what this PR did

when RM receive UndoLogDeleteRequest(send by TC), if user does not use AT mode at all(which mean their database does not have undo_log table), exception would occur(such as undo_log table doesn't existed~) and logger will print error info(which scares user~). Here, we check whether undo_log table exist before trying to delete undolog.

@funky-eyes funky-eyes added this to the 1.5.0 milestone Dec 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2021

Codecov Report

Merging #4216 (9105ef3) into develop (14907c2) will increase coverage by 0.04%.
The diff coverage is 43.13%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4216      +/-   ##
=============================================
+ Coverage      48.98%   49.03%   +0.04%     
- Complexity      3772     3780       +8     
=============================================
  Files            720      720              
  Lines          24001    24031      +30     
  Branches        2927     2931       +4     
=============================================
+ Hits           11758    11783      +25     
+ Misses         11040    11038       -2     
- Partials        1203     1210       +7     
Impacted Files Coverage Δ
...ata/rm/datasource/undo/AbstractUndoLogManager.java 49.72% <12.50%> (-1.71%) ⬇️
...asource/src/main/java/io/seata/rm/RMHandlerAT.java 46.42% <48.78%> (+46.42%) ⬆️
...m/datasource/undo/oracle/OracleUndoLogManager.java 11.76% <50.00%> (+2.38%) ⬆️
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caohdgege
Copy link
Contributor

补充一下md

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 758642c into apache:develop Dec 25, 2021
@selfishlover selfishlover deleted the check-undo-local branch December 25, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants