Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: skip check lock when all the before image is empty #4237

Merged
merged 4 commits into from
Jan 5, 2022

Conversation

caohdgege
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #4236

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #4237 (3c4fc60) into develop (b03abc8) will decrease coverage by 0.02%.
The diff coverage is 54.63%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4237      +/-   ##
=============================================
- Coverage      48.87%   48.85%   -0.03%     
  Complexity      3799     3799              
=============================================
  Files            724      724              
  Lines          24203    24218      +15     
  Branches        2957     2965       +8     
=============================================
+ Hits           11829    11831       +2     
- Misses         11150    11155       +5     
- Partials        1224     1232       +8     
Impacted Files Coverage Δ
...ommon/src/main/java/io/seata/common/Constants.java 100.00% <ø> (ø)
...rc/main/java/io/seata/core/lock/LocalDBLocker.java 0.00% <ø> (ø)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 25.00% <ø> (ø)
...ver/storage/db/lock/DataBaseDistributedLocker.java 0.86% <ø> (ø)
.../io/seata/server/storage/file/lock/FileLocker.java 79.12% <0.00%> (ø)
...java/io/seata/rm/datasource/ConnectionContext.java 74.35% <18.18%> (-6.02%) ⬇️
...o/seata/server/storage/redis/lock/RedisLocker.java 39.48% <33.33%> (-0.21%) ⬇️
...in/java/io/seata/server/transaction/at/ATCore.java 44.11% <40.00%> (+0.78%) ⬆️
...o/seata/server/storage/db/lock/DataBaseLocker.java 14.58% <50.00%> (ø)
...a/server/storage/db/lock/LockStoreDataBaseDAO.java 52.09% <80.48%> (-0.47%) ⬇️
... and 2 more

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added module/rm-datasource rm-datasource module module/server server module labels Dec 28, 2021
@funky-eyes funky-eyes added this to the 1.5.0 milestone Dec 28, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimize request: optimize the lock logic when before image is empty
4 participants