bugfix: update executor store the actually modified columns but not only the columns in set condition
#4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4253 +/- ##
=============================================
- Coverage 48.33% 48.33% -0.01%
- Complexity 3969 3973 +4
=============================================
Files 734 734
Lines 25279 25300 +21
Branches 3105 3109 +4
=============================================
+ Hits 12218 12228 +10
- Misses 11740 11748 +8
- Partials 1321 1324 +3
|
caohdgege
changed the title
set condition
1 task
funky-eyes
added
module/rm-datasource
l81893521
reviewed
Mar 3, 2022
这个在驱动层面就是通过 |
slievrly
reviewed
Mar 11, 2022
| @@ -115,7 +115,8 @@ private TableMeta resultSetMetaToSchema(ResultSetMetaData rsmd, DatabaseMetaData | |||
| */ | |||
|
|
|||
| try (ResultSet rsColumns = dbmd.getColumns(catalogName, schemaName, tableName, "%"); | |||
| ResultSet rsIndex = dbmd.getIndexInfo(catalogName, schemaName, tableName, false, true)) { | |||
| ResultSet rsIndex = dbmd.getIndexInfo(catalogName, schemaName, tableName, false, true); | |||
| ResultSet onUpdateColumns = dbmd.getVersionColumns(catalogName, schemaName, tableName)) { | |||
There was a problem hiding this comment.
Whether virtual columns are included ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #3822
fixes #3036
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews