Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix can not deserialize blob/clob/nclob data type when use mysql #4278

Merged
merged 7 commits into from
Jan 13, 2022

Conversation

GoodBoyCoder
Copy link
Contributor

@GoodBoyCoder GoodBoyCoder commented Jan 10, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Convert Blob, Clob, NClob types to Serial corresponding types to avoid deserialization failure due to the absence of a parameterless constructor

Ⅱ. Does this pull request fix one issue?

fixes #4249

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug. labels Jan 10, 2022
@funky-eyes funky-eyes added this to the 1.5.0 milestone Jan 10, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2022

Codecov Report

Merging #4278 (0c2575e) into develop (80edb05) will decrease coverage by 0.01%.
The diff coverage is 15.38%.

❗ Current head 0c2575e differs from pull request most recent head 299ceb2. Consider uploading reports for the commit 299ceb2 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4278      +/-   ##
=============================================
- Coverage      48.77%   48.76%   -0.02%     
- Complexity      3797     3800       +3     
=============================================
  Files            724      724              
  Lines          24220    24232      +12     
  Branches        2969     2972       +3     
=============================================
+ Hits           11813    11816       +3     
- Misses         11164    11171       +7     
- Partials        1243     1245       +2     
Impacted Files Coverage Δ
...o/seata/rm/datasource/sql/struct/TableRecords.java 67.61% <15.38%> (-7.65%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 79.31% <0.00%> (+0.43%) ⬆️
...o/seata/server/coordinator/DefaultCoordinator.java 48.38% <0.00%> (+0.53%) ⬆️

Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added the first-time contributor first-time contributor label Jan 12, 2022
@funky-eyes funky-eyes merged commit b6719a0 into apache:develop Jan 13, 2022
miaoxueyu pushed a commit to miaoxueyu/seata that referenced this pull request Jan 13, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GoodBoyCoder GoodBoyCoder deleted the fix_jacksonparser branch April 26, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

回滚的时候Geometry类型无法反序列化
5 participants