-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:fix can not deserialize blob/clob/nclob data type when use mysql #4278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #4278 +/- ##
=============================================
- Coverage 48.77% 48.76% -0.02%
- Complexity 3797 3800 +3
=============================================
Files 724 724
Lines 24220 24232 +12
Branches 2969 2972 +3
=============================================
+ Hits 11813 11816 +3
- Misses 11164 11171 +7
- Partials 1243 1245 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Convert Blob, Clob, NClob types to Serial corresponding types to avoid deserialization failure due to the absence of a parameterless constructor
Ⅱ. Does this pull request fix one issue?
fixes #4249
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews