Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Realize the interface of console: get global session and global lock in the redis mode #4281

Merged
merged 54 commits into from
Feb 24, 2022
Merged

feature: Realize the interface of console: get global session and global lock in the redis mode #4281

merged 54 commits into from
Feb 24, 2022

Conversation

doubleDimple
Copy link
Contributor

@doubleDimple doubleDimple commented Jan 10, 2022 •
edited

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #4261
fixes #4260

Ⅲ. Why don't you add test cases (unit test/integration test)?

yes，see:
RedisTransactionStoreManagerTest
RedisQueryConsolTest

Ⅳ. Describe how to verify it

redis mode: query GlobalSession
redis mode:query GlobalLock

Ⅴ. Special notes for reviews

@doubleDimple doubleDimple changed the title query redis globalSession code optimize:query redis globalSession code Jan 11, 2022
@doubleDimple
Copy link
Contributor Author

redis分页需要的总数total目前暂时用keys获取的，暂时没想到好的方法，还是不要这个total前端没法统计总页数，第一次提交开源代码代码写的不好的地方请多多指教

@slievrly slievrly added the first-time contributor first-time contributor label Jan 12, 2022
@doubleDimple doubleDimple changed the title optimize:query redis globalSession code [WIP]optimize:query redis globalSession code Jan 12, 2022
@doubleDimple doubleDimple changed the title [WIP]optimize:query redis globalSession code Feature:query redis GlobalSession and GlobalLock code Jan 14, 2022
@funky-eyes funky-eyes changed the title Feature:query redis GlobalSession and GlobalLock code feature:query redis GlobalSession and GlobalLock code Jan 14, 2022
@funky-eyes funky-eyes changed the title feature:query redis GlobalSession and GlobalLock code feature: query redis GlobalSession and GlobalLock code Jan 14, 2022
funky-eyes
funky-eyes reviewed Jan 14, 2022
View reviewed changes
server/src/main/java/io/seata/server/console/impl/redis/GlobalLockRedisServiceImpl.java Outdated Show resolved Hide resolved
server/src/main/java/io/seata/server/console/impl/redis/BranchSessionRedisServiceImpl.java Outdated Show resolved Hide resolved
server/src/main/java/io/seata/server/console/impl/redis/GlobalLockRedisServiceImpl.java Outdated Show resolved Hide resolved
server/src/main/java/io/seata/server/console/impl/redis/GlobalSessionRedisServiceImpl.java Outdated Show resolved Hide resolved
server/src/main/java/io/seata/server/console/impl/redis/GlobalSessionRedisServiceImpl.java Outdated Show resolved Hide resolved
server/src/main/java/io/seata/server/console/impl/redis/GlobalSessionRedisServiceImpl.java Outdated Show resolved Hide resolved
server/src/main/java/io/seata/server/console/impl/redis/GlobalSessionRedisServiceImpl.java Outdated Show resolved Hide resolved
server/src/main/java/io/seata/server/console/impl/redis/GlobalSessionRedisServiceImpl.java Outdated Show resolved Hide resolved
server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java Outdated Show resolved Hide resolved
server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java Outdated Show resolved Hide resolved
@doubleDimple
Copy link
Contributor Author

review’s problem has been completely modified please review again !

doubleDimple and others added 5 commits February 8, 2022 21:01
@doubleDimple
Merge branch 'develop' of github.com:seata/seata into develop
3d9b17c 
# Conflicts:
#	changes/1.5.0.md
#	changes/en-us/1.5.0.md
#	core/src/main/java/io/seata/core/console/result/PageResult.java
#	server/src/main/java/io/seata/server/storage/SessionConverter.java
@doubleDimple
close piplied
4baba76
@doubleDimple
Merge branch 'develop' into develop
7bba2bb
@doubleDimple
add rowLockkey test
575c879
@doubleDimple
add rowLockkey test
e917094
@lightClouds917 lightClouds917 changed the title feature: query redis GlobalSession and GlobalLock code feature: Realize the interface of console: get global session and global lock in the redis mode Feb 11, 2022
doubleDimple and others added 5 commits February 13, 2022 09:06
@doubleDimple
optimize query globalSession condition judge
ac85f0e
@doubleDimple
Merge branch 'develop' of github.com:seata/seata into develop
d6ee786 
# Conflicts:
#	server/src/main/java/io/seata/server/session/SessionCondition.java
#	server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java
@doubleDimple
Resolve code conflicts
0dbad8b
@doubleDimple
Merge branch 'develop' into develop
08a0347
@doubleDimple
Merge branch 'develop' into develop
8ecea26
funky-eyes
funky-eyes requested changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要有任何地方与下行代码间隔两行

server/src/main/java/io/seata/server/session/SessionCondition.java Outdated Show resolved Hide resolved
server/src/main/java/io/seata/server/storage/SessionConverter.java Show resolved Hide resolved
server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java Outdated Show resolved Hide resolved
server/src/test/java/io/seata/server/session/redis/RedisQueryConsolTest.java Outdated Show resolved Hide resolved
server/src/test/java/io/seata/server/session/redis/RedisQueryConsolTest.java Outdated Show resolved Hide resolved
server/src/test/java/io/seata/server/session/redis/RedisTransactionStoreManagerTest.java Outdated Show resolved Hide resolved
server/src/test/java/io/seata/server/session/redis/RedisTransactionStoreManagerTest.java Outdated Show resolved Hide resolved
server/src/test/java/io/seata/server/session/redis/RedisTransactionStoreManagerTest.java Outdated Show resolved Hide resolved
server/src/test/java/io/seata/server/session/redis/RedisTransactionStoreManagerTest.java Outdated Show resolved Hide resolved
server/src/test/java/io/seata/server/session/redis/RedisTransactionStoreManagerTest.java Outdated Show resolved Hide resolved
funky-eyes
funky-eyes approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit d4b265f into apache:develop Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bughue Bughue Bughue approved these changes

@funky-eyes funky-eyes funky-eyes approved these changes

@lightClouds917 lightClouds917 lightClouds917 approved these changes

Assignees
No one assigned
Labels
first-time contributor first-time contributor module/server server module type: feature Category issues or prs related to feature request.
Projects
None yet
Milestone
1.5.0 (1.5.1)
6 participants
@doubleDimple @caohdgege @Bughue @funky-eyes @lightClouds917 @slievrly