Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize exceptions to make them friendly #4299

Merged
merged 6 commits into from
Jan 22, 2022
Merged

optimize: optimize exceptions to make them friendly #4299

merged 6 commits into from
Jan 22, 2022

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Jan 16, 2022

Signed-off-by: slievrly slievrly@163.com

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize exceptions to make them friendly

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone Jan 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2022

Codecov Report

Merging #4299 (f4bf4ad) into develop (a09a279) will decrease coverage by 0.01%.
The diff coverage is 54.54%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4299      +/-   ##
=============================================
- Coverage      48.50%   48.49%   -0.02%     
+ Complexity      3825     3821       -4     
=============================================
  Files            726      726              
  Lines          24423    24410      -13     
  Branches        3009     3008       -1     
=============================================
- Hits           11847    11838       -9     
+ Misses         11323    11319       -4     
  Partials        1253     1253              
Impacted Files Coverage Δ
...io/seata/common/exception/DataAccessException.java 100.00% <ø> (ø)
...eata/common/exception/EurekaRegistryException.java 100.00% <ø> (ø)
...java/io/seata/common/exception/RedisException.java 0.00% <ø> (ø)
...a/common/exception/ShouldNeverHappenException.java 100.00% <ø> (ø)
...java/io/seata/common/exception/StoreException.java 100.00% <ø> (ø)
...java/io/seata/rm/datasource/ConnectionContext.java 74.35% <0.00%> (ø)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 25.00% <0.00%> (ø)
...java/io/seata/rm/datasource/DataSourceManager.java 24.39% <0.00%> (ø)
...eata/rm/datasource/exec/LockConflictException.java 75.00% <ø> (-5.00%) ⬇️
.../seata/rm/datasource/undo/UndoExecutorFactory.java 75.00% <0.00%> (ø)
... and 6 more

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@objcoding objcoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@objcoding objcoding merged commit 8df3ab0 into apache:develop Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants