-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:fix other orm could not get generated keys #4302
Merged
slievrly
merged 7 commits into
apache:develop
from
GoodBoyCoder:fix-generated-keys-not-scrollable
Jan 24, 2022
Merged
bugfix:fix other orm could not get generated keys #4302
slievrly
merged 7 commits into
apache:develop
from
GoodBoyCoder:fix-generated-keys-not-scrollable
Jan 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4302 +/- ##
=============================================
- Coverage 48.52% 48.51% -0.02%
+ Complexity 3830 3829 -1
=============================================
Files 728 728
Lines 24470 24471 +1
Branches 3026 3027 +1
=============================================
- Hits 11875 11872 -3
- Misses 11329 11331 +2
- Partials 1266 1268 +2
|
funky-eyes
requested review from
jsbxyyx and
caohdgege
and removed request for
jsbxyyx
January 18, 2022 12:35
funky-eyes
added
module/rm-datasource
rm-datasource module
type: bug
Category issues or prs related to bug.
labels
Jan 18, 2022
funky-eyes
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
slievrly
reviewed
Jan 24, 2022
rm-datasource/src/main/java/io/seata/rm/datasource/AbstractStatementProxy.java
Show resolved
Hide resolved
slievrly
approved these changes
Jan 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #4035
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews