optimize: acquire global lock fail error log print on tc #4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinocchio2018
force-pushed
the
develop_优化server端全局锁失败日志打印
branch
from
b5cd45f
to
4621cec
Compare
slievrly
reviewed
Jan 22, 2022
core/src/main/java/io/seata/core/exception/AbstractExceptionHandler.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #4305 +/- ##
=============================================
- Coverage 49.01% 48.98% -0.03%
Complexity 3953 3953
=============================================
Files 733 733
Lines 24978 24988 +10
Branches 3092 3093 +1
=============================================
- Hits 12242 12240 -2
- Misses 11439 11450 +11
- Partials 1297 1298 +1
|
…chio2018/seata into 优化server端全局锁失败日志打印_local
…chio2018/seata into 优化server端全局锁失败日志打印_local � Conflicts: � changes/en-us/1.5.0.md
funky-eyes
reviewed
Jan 25, 2022
core/src/main/java/io/seata/core/exception/AbstractExceptionHandler.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Jan 25, 2022
core/src/main/java/io/seata/core/exception/AbstractExceptionHandler.java
Outdated
Show resolved
Hide resolved
lightClouds917
suggested changes
Jan 25, 2022
core/src/main/java/io/seata/core/exception/AbstractExceptionHandler.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/exception/AbstractExceptionHandler.java
Show resolved
Hide resolved
lightClouds917
changed the title
objcoding
reviewed
Jan 27, 2022
core/src/main/java/io/seata/core/exception/AbstractExceptionHandler.java
Outdated
Show resolved
Hide resolved
… develop_优化server端全局锁失败日志打印
funky-eyes
requested changes
Feb 9, 2022
| @@ -272,8 +272,13 @@ private boolean acquireLockByLua(Jedis jedis, List<RowLock> rowLocks) { | |||
| args.add(lockKeysString.toString()); | |||
| // reset args index 2 | |||
| args.set(1, String.valueOf(args.size())); | |||
| long result = (long)jedis.evalsha(ACQUIRE_LOCK_SHA, keys, args); | |||
| return SUCCEED == result; | |||
| String xIdOwnLock = (String) jedis.evalsha(ACQUIRE_LOCK_SHA, keys, args); | |||
There was a problem hiding this comment.
现在是这样的，redis存储，lua模式和pipeline模式都打印这样的日志
20:58:10.287 INFO --- [rverHandlerThread_1_9_500] i.s.s.storage.redis.lock.RedisLocker : tx:[192.168.121.1:8091:2576290387922075649] acquire Global lock failed. Global lock on [SEATA_ROW_LOCK_jdbc:mysql://localhost:3306/seata_stock^^^product^^^1] is holding by xid 192.168.121.1:8091:2576290387922075651
20:58:10.287 INFO --- [rverHandlerThread_1_9_500] i.s.c.e.AbstractExceptionHandler : this request cannot acquire global lock, you can let Seata retry by setting config [client.rm.lock.retryPolicyBranchRollbackOnConflict] = false or manually retry by yourself. request: xid=192.168.121.1:8091:2576290387922075649,branchType=AT,resourceId=jdbc:mysql://localhost:3306/seata_stock,lockKey=product:1
funky-eyes
requested changes
Feb 21, 2022
core/src/main/java/io/seata/core/exception/AbstractExceptionHandler.java
Outdated
Show resolved
Hide resolved
lightClouds917
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize error log print on tc when acquire global lock fail
Ⅱ. Does this pull request fix one issue?
fixes #4152
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
I test it with seata-samples
Ⅴ. Special notes for reviews