-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:Fix fetch PostgresqlTableMetaCache fail when the same table exists in different schemas #4308
bugfix:Fix fetch PostgresqlTableMetaCache fail when the same table exists in different schemas #4308
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4308 +/- ##
=============================================
- Coverage 48.53% 48.53% -0.01%
- Complexity 3799 3800 +1
=============================================
Files 725 725
Lines 24305 24306 +1
Branches 2984 2984
=============================================
Hits 11797 11797
- Misses 11259 11261 +2
+ Partials 1249 1248 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
如果SQL表名没有写明schema,使用connection获取当前连接的schema,防止不同schema下存在相同表而导致错误识别多主键
If the SQL table name does not specify schema, use connection to obtain the schema of the current connection to prevent the existence of the same table under different schemas and cause misidentification of multiple primary keys
Ⅱ. Does this pull request fix one issue?
fixes #3098
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews