Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fixed inability to build Executor when using mariadb driver #4326

Merged
merged 6 commits into from
Jan 22, 2022

Conversation

funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #3697

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022

Codecov Report

Merging #4326 (2a296ba) into develop (1f3bcc5) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4326   +/-   ##
==========================================
  Coverage      48.50%   48.50%           
- Complexity      3822     3824    +2     
==========================================
  Files            726      726           
  Lines          24419    24423    +4     
  Branches        3008     3009    +1     
==========================================
+ Hits           11844    11847    +3     
- Misses         11321    11323    +2     
+ Partials        1254     1253    -1     
Impacted Files Coverage Δ
...a/io/seata/rm/datasource/exec/ExecuteTemplate.java 5.55% <0.00%> (-0.33%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 48.91% <ø> (ø)
...n/java/io/seata/rm/datasource/DataSourceProxy.java 47.05% <100.00%> (+1.60%) ⬆️
.../main/java/io/seata/rm/datasource/ColumnUtils.java 87.62% <0.00%> (+1.03%) ⬆️

@funky-eyes funky-eyes added this to the 1.5.0 milestone Jan 21, 2022
@funky-eyes funky-eyes added module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug. labels Jan 21, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lightClouds917 lightClouds917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit a09a279 into apache:develop Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support mariadb AT mode
4 participants