Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: upload configuration script support comments #4328

Merged
merged 3 commits into from
Jan 25, 2022
Merged

optimize: upload configuration script support comments #4328

merged 3 commits into from
Jan 25, 2022

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

upload configuration script support comments

#comments

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2022

Codecov Report

Merging #4328 (ccb0e94) into develop (d87e8c9) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4328      +/-   ##
=============================================
- Coverage      48.52%   48.51%   -0.02%     
+ Complexity      3830     3829       -1     
=============================================
  Files            728      728              
  Lines          24472    24472              
  Branches        3027     3027              
=============================================
- Hits           11875    11872       -3     
- Misses         11330    11332       +2     
- Partials        1267     1268       +1     
Impacted Files Coverage Δ
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️

@xingfudeshi xingfudeshi self-requested a review January 25, 2022 01:39
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wangyuewen-china wangyuewen-china left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed, can be merged

@slievrly slievrly merged commit e7d6321 into apache:develop Jan 25, 2022
@slievrly slievrly added the module/script script module label Jan 25, 2022
@slievrly slievrly added this to the 1.5.0 milestone Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/script script module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants