Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix dirty write check exception that may occur when using ONLY_CARE_UPDATE_COLUMNS #4331

Merged
merged 4 commits into from
Jan 24, 2022

Conversation

GoodBoyCoder
Copy link
Contributor

@GoodBoyCoder GoodBoyCoder commented Jan 24, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

使用TreeSet代替HashSet进行字段去重

Use TreeSet instead of HashSet to perform field deduplication

Ⅱ. Does this pull request fix one issue?

fixes #4330

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2022

Codecov Report

Merging #4331 (440ddcc) into develop (3993984) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 440ddcc differs from pull request most recent head d89ff73. Consider uploading reports for the commit d89ff73 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4331      +/-   ##
=============================================
- Coverage      48.52%   48.52%   -0.01%     
- Complexity      3830     3833       +3     
=============================================
  Files            728      728              
  Lines          24470    24471       +1     
  Branches        3026     3025       -1     
=============================================
- Hits           11875    11874       -1     
- Misses         11329    11332       +3     
+ Partials        1266     1265       -1     
Impacted Files Coverage Δ
.../rm/datasource/exec/BaseTransactionalExecutor.java 55.92% <0.00%> (-0.38%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 79.31% <0.00%> (+0.43%) ⬆️
...o/seata/server/coordinator/DefaultCoordinator.java 49.35% <0.00%> (+0.43%) ⬆️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone Jan 24, 2022
@funky-eyes funky-eyes added module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug. labels Jan 24, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GoodBoyCoder GoodBoyCoder changed the title bugfix:fix double pk columns when using ONLY_CARE_UPDATE_COLUMNS bugfix:fix dirty write check exception that may occur when using ONLY_CARE_UPDATE_COLUMNS configuration Jan 24, 2022
@slievrly slievrly changed the title bugfix:fix dirty write check exception that may occur when using ONLY_CARE_UPDATE_COLUMNS configuration bugfix:fix dirty write check exception that may occur when using ONLY_CARE_UPDATE_COLUMNS Jan 24, 2022
@slievrly slievrly merged commit d87e8c9 into apache:develop Jan 24, 2022
@GoodBoyCoder GoodBoyCoder deleted the bugfix_double_pk_colums branch April 26, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AT模式脏写校验异常
4 participants