Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize upload configuration script with interaction (nacos, etcd3) #4335

Merged
merged 9 commits into from
Jan 25, 2022
Merged

optimize: optimize upload configuration script with interaction (nacos, etcd3) #4335

merged 9 commits into from
Jan 25, 2022

Conversation

wangyuewen-china
Copy link
Contributor

@wangyuewen-china wangyuewen-china commented Jan 25, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

feature: Realize configuration center upload configuration interactive script (nacos、etcd3)

Ⅱ. Does this pull request fix one issue?

fix:#4333

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly added first-time contributor first-time contributor module/script script module labels Jan 25, 2022
@slievrly slievrly changed the title [feature] Realize configuration center upload configuration interactive script (nacos、etcd3) optimize: optimize configuration center upload configuration script with interaction (nacos, etcd3) Jan 25, 2022
@slievrly slievrly changed the title optimize: optimize configuration center upload configuration script with interaction (nacos, etcd3) optimize: optimize upload configuration script with interaction (nacos, etcd3) Jan 25, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test ok.

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022

Codecov Report

Merging #4335 (f664b14) into develop (e7d6321) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head f664b14 differs from pull request most recent head 4117991. Consider uploading reports for the commit 4117991 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4335      +/-   ##
=============================================
+ Coverage      48.42%   48.51%   +0.08%     
- Complexity      3830     3831       +1     
=============================================
  Files            728      728              
  Lines          24471    24472       +1     
  Branches        2995     3026      +31     
=============================================
+ Hits           11850    11872      +22     
- Misses         11330    11332       +2     
+ Partials        1291     1268      -23     
Impacted Files Coverage Δ
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
...a/server/storage/db/store/LogStoreDataBaseDAO.java 76.58% <0.00%> (+0.31%) ⬆️
...ing/annotation/GlobalTransactionalInterceptor.java 31.92% <0.00%> (+0.41%) ⬆️
...buf/convertor/BranchRollbackResponseConvertor.java 100.00% <0.00%> (+2.94%) ⬆️
...tobuf/convertor/BranchCommitResponseConvertor.java 100.00% <0.00%> (+3.03%) ⬆️
...buf/convertor/GlobalRollbackResponseConvertor.java 100.00% <0.00%> (+3.22%) ⬆️
...tobuf/convertor/GlobalCommitResponseConvertor.java 100.00% <0.00%> (+3.33%) ⬆️
...tobuf/convertor/GlobalStatusResponseConvertor.java 100.00% <0.00%> (+3.33%) ⬆️
...rotobuf/convertor/RegisterRMResponseConvertor.java 82.75% <0.00%> (+3.44%) ⬆️
...rotobuf/convertor/RegisterTMResponseConvertor.java 82.75% <0.00%> (+3.44%) ⬆️
... and 14 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/script script module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants