-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimize upload configuration script with interaction (nacos, etcd3) #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slievrly
added
first-time contributor
first-time contributor
module/script
script module
labels
Jan 25, 2022
update config script
slievrly
changed the title
[feature] Realize configuration center upload configuration interactive script (nacos、etcd3)
optimize: optimize configuration center upload configuration script with interaction (nacos, etcd3)
Jan 25, 2022
slievrly
changed the title
optimize: optimize configuration center upload configuration script with interaction (nacos, etcd3)
optimize: optimize upload configuration script with interaction (nacos, etcd3)
Jan 25, 2022
slievrly
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, test ok.
Codecov Report
@@ Coverage Diff @@
## develop #4335 +/- ##
=============================================
+ Coverage 48.42% 48.51% +0.08%
- Complexity 3830 3831 +1
=============================================
Files 728 728
Lines 24471 24472 +1
Branches 2995 3026 +31
=============================================
+ Hits 11850 11872 +22
- Misses 11330 11332 +2
+ Partials 1291 1268 -23
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
feature: Realize configuration center upload configuration interactive script (nacos、etcd3)
Ⅱ. Does this pull request fix one issue?
fix:#4333
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews