optimize:add SQL exception of not supported by AT mode #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4336 +/- ##
=============================================
+ Coverage 48.43% 48.75% +0.32%
- Complexity 3862 3903 +41
=============================================
Files 733 733
Lines 24766 24829 +63
Branches 3002 3057 +55
=============================================
+ Hits 11995 12106 +111
+ Misses 11476 11444 -32
+ Partials 1295 1279 -16
|
funky-eyes
reviewed
Jan 25, 2022
...uid/src/main/java/io/seata/sqlparser/druid/postgresql/PostgresqlOperateRecognizerHolder.java
Outdated
Show resolved
Hide resolved
lightClouds917
suggested changes
Jan 25, 2022
...eata-sqlparser-druid/src/main/java/io/seata/sqlparser/druid/oracle/BaseOracleRecognizer.java
Outdated
Show resolved
Hide resolved
sqlparser/seata-sqlparser-druid/src/main/java/io/seata/sqlparser/druid/BaseRecognizer.java
Outdated
Show resolved
Hide resolved
|
https://seata.io/zh-cn/docs/user/sqlreference/sql-restrictions.html 文档里，大佬要不麻烦也给个样例sql。😄 |
caohdgege
reviewed
Jan 25, 2022
...ta-sqlparser-druid/src/test/java/io/seata/sqlparser/druid/DruidSQLRecognizerFactoryTest.java
Outdated
Show resolved
Hide resolved
|
LGTM |
lightClouds917
changed the title
slievrly
reviewed
Feb 1, 2022
| } | ||
|
|
||
| @Override | ||
| public boolean visit(SQLSubqueryTableSource x) { |
There was a problem hiding this comment.
That's right. And the example statement is to illustrate the scope of SQLSubqueryTableSource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
添加AT模式不支持的SQL语句异常提示
Ⅱ. Does this pull request fix one issue?
fixes #4324
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews