Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize the log of the server and remove lombok #4346

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Jan 27, 2022

optimize: optimize the log of the server and remove lombok

  1. 优化Server端的日志
  2. 移除 lombok

#4227 PR太大,慢慢拆分出来

@slievrly
Copy link
Member

image

@wangliang181230
Copy link
Contributor Author

image

偶发的。。。这个PR里不处理。

@codecov-commenter
Copy link

Codecov Report

Merging #4346 (dc74896) into develop (5a5abd5) will decrease coverage by 0.06%.
The diff coverage is 28.57%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4346      +/-   ##
=============================================
- Coverage      48.65%   48.59%   -0.07%     
+ Complexity      3859     3858       -1     
=============================================
  Files            732      733       +1     
  Lines          24716    24751      +35     
  Branches        3054     3057       +3     
=============================================
+ Hits           12026    12027       +1     
- Misses         11416    11448      +32     
- Partials        1274     1276       +2     
Impacted Files Coverage Δ
.../io/seata/core/rpc/netty/NettyServerBootstrap.java 0.00% <0.00%> (ø)
...etrics/exporter/prometheus/PrometheusExporter.java 9.09% <42.85%> (ø)
...torage/file/store/FileTransactionStoreManager.java 56.77% <100.00%> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 48.05% <0.00%> (-0.44%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 78.87% <0.00%> (-0.44%) ⬇️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 1555b9a into apache:develop Jan 27, 2022
@wangliang181230 wangliang181230 deleted the optimize-log branch January 27, 2022 06:51
@wangliang181230 wangliang181230 added this to the 1.5.0 milestone Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants