-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: Slimming down for the seata-all.jar
#4353
Merged
wangliang181230
merged 25 commits into
apache:develop
from
wangliang181230:optimize/seata-all
Feb 14, 2022
Merged
optimize: Slimming down for the seata-all.jar
#4353
wangliang181230
merged 25 commits into
apache:develop
from
wangliang181230:optimize/seata-all
Feb 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Jan 28, 2022
funky-eyes
reviewed
Jan 28, 2022
core/src/main/java/io/seata/core/serializer/SerializerServiceLoader.java
Show resolved
Hide resolved
# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/util/JdbcUtils.java
Codecov Report
@@ Coverage Diff @@
## develop #4353 +/- ##
==========================================
Coverage 48.87% 48.87%
- Complexity 3935 3938 +3
==========================================
Files 732 733 +1
Lines 24894 24900 +6
Branches 3068 3068
==========================================
+ Hits 12166 12170 +4
- Misses 11446 11451 +5
+ Partials 1282 1279 -3
|
优化seata-distribution的配置。
slievrly
reviewed
Feb 4, 2022
slievrly
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
funky-eyes
approved these changes
Feb 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimize: Slimming down for the
seata-all.jar
.seata-all
瘦身:移除seata-sqlparser-antlr
和seata-serializer-protobuf
,因为他们体积太大了。需要的用户自行引用依赖。另外,优化了用户未引用依赖时的错误提示信息,提示用户引用相应的依赖。seata-all
和seata-bom
中补充缺失的模块:seata-hsf
、seata-compressor-zstd