-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimize the tests of SAGA
#4354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4354 +/- ##
=============================================
+ Coverage 48.85% 48.94% +0.08%
- Complexity 3935 3953 +18
=============================================
Files 733 733
Lines 24900 24968 +68
Branches 3068 3087 +19
=============================================
+ Hits 12166 12220 +54
- Misses 11452 11453 +1
- Partials 1282 1295 +13
|
This reverts commit b343b14.
wangliang181230
changed the title
尝试解决saga单元测试的问题
test: optimize tests, and temporarily disable Jan 29, 2022
SAGA
tests with frequent errors
wangliang181230
requested review from
long187,
l81893521,
funky-eyes and
slievrly
January 29, 2022 10:42
wangliang181230
commented
Jan 29, 2022
slievrly
reviewed
Feb 1, 2022
long187
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
funky-eyes
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wangliang181230
changed the title
test: optimize tests, and temporarily disable
test: optimize the tests of Feb 14, 2022
SAGA
tests with frequent errorsSAGA
wangliang181230
changed the title
test: optimize the tests of
optimize: optimize the tests of Feb 14, 2022
SAGA
SAGA
slievrly
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAGA
相关的测试的日志,方便查看单测的耗时。SAGA
测试用例中,callback和wait的代码。每个单测独立使用一个Object来进行wait和notifyAll.SAGA
的单测中,sleep时间减半,减少单测耗时,由原来的1112分钟,降低到了89分钟。mvn -T 4C clean install
另外:
antrun
插件,只在release-seata
和release
的profile
下才执行,在单测时,这个插件出现过卡死的情况。assertTrue
调整为assertEquals
,方便观察实际值。assertEquals
的预期值
和实际值
传参反了。