bugfix: fix mysql-loadbalance resource id error #4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
added
module/rm-datasource
Codecov Report
@@ Coverage Diff @@
## develop #4355 +/- ##
=============================================
+ Coverage 48.75% 48.77% +0.01%
- Complexity 3903 3908 +5
=============================================
Files 733 733
Lines 24829 24846 +17
Branches 3057 3061 +4
=============================================
+ Hits 12106 12119 +13
- Misses 11444 11447 +3
- Partials 1279 1280 +1
|
pengten
approved these changes
Feb 7, 2022
funky-eyes
changed the title
l81893521
reviewed
Feb 8, 2022
rm-datasource/src/main/java/io/seata/rm/datasource/DataSourceProxy.java
Outdated
Show resolved
Hide resolved
l81893521
reviewed
Feb 8, 2022
rm-datasource/src/main/java/io/seata/rm/datasource/DataSourceProxy.java
Outdated
Show resolved
Hide resolved
pengten
reviewed
Feb 8, 2022
| initPGResourceId(); | ||
| } else if (JdbcConstants.ORACLE.equals(dbType) && userName != null) { | ||
| initDefaultResourceId(); | ||
| resourceId = resourceId + "/" + userName; |
There was a problem hiding this comment.
并发获取resourceId情况下这里貌似会有问题
datasource以及connection本身都不保证线程安全
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #4344
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews