Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add configuration center upload configuration interactive script (apollo,consul,zk) #4360

Merged
merged 4 commits into from
Feb 16, 2022

Conversation

renliangyu857
Copy link
Contributor

…(apollo,consul,zk) #4332Realize configuration center upload configuration interactive script (apollo,consul,zk) #4332

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Realize configuration center upload configuration interactive script (apollo,consul,zk) #4332

Ⅱ. Does this pull request fix one issue?

#4332

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

…(apollo,consul,zk) #4332Realize configuration center upload configuration interactive script (apollo,consul,zk) apache#4332
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

Merging #4360 (bd4be2f) into develop (ca8ff3f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4360   +/-   ##
==========================================
  Coverage      48.93%   48.94%           
  Complexity      3953     3953           
==========================================
  Files            733      733           
  Lines          24968    24968           
  Branches        3087     3087           
==========================================
+ Hits           12219    12220    +1     
+ Misses         11454    11453    -1     
  Partials        1295     1295           
Impacted Files Coverage Δ
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️

@slievrly
Copy link
Member

@imherewait Please help on the https://github.com/seata/seata/blob/develop/script/config-center/README.md introduce the use of interactive script.


请帮忙在https://github.com/seata/seata/blob/develop/script/config-center/README.md 介绍下可交互脚本的使用。

@renliangyu857
Copy link
Contributor Author

@imherewait Please help on the https://github.com/seata/seata/blob/develop/script/config-center/README.md introduce the use of interactive script.

请帮忙在https://github.com/seata/seata/blob/develop/script/config-center/README.md 介绍下可交互脚本的使用。

好的

@slievrly slievrly added the module/script script module label Feb 10, 2022
@renliangyu857
Copy link
Contributor Author

@imherewait Please help on the https://github.com/seata/seata/blob/develop/script/config-center/README.md introduce the use of interactive script.

请帮忙在https://github.com/seata/seata/blob/develop/script/config-center/README.md 介绍下可交互脚本的使用。

已完成,请帮忙再review一下

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title Realize configuration center upload configuration interactive script … optimize: add configuration center upload configuration interactive script (apollo,consul,zk) Feb 16, 2022
@slievrly slievrly added this to the 1.5.0 milestone Feb 16, 2022
@slievrly slievrly merged commit 732f287 into apache:develop Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/script script module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants