-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: add configuration center upload configuration interactive script (apollo,consul,zk) #4360
optimize: add configuration center upload configuration interactive script (apollo,consul,zk) #4360
Conversation
…(apollo,consul,zk) #4332Realize configuration center upload configuration interactive script (apollo,consul,zk) apache#4332
Codecov Report
@@ Coverage Diff @@
## develop #4360 +/- ##
==========================================
Coverage 48.93% 48.94%
Complexity 3953 3953
==========================================
Files 733 733
Lines 24968 24968
Branches 3087 3087
==========================================
+ Hits 12219 12220 +1
+ Misses 11454 11453 -1
Partials 1295 1295
|
@imherewait Please help on the https://github.com/seata/seata/blob/develop/script/config-center/README.md introduce the use of interactive script. 请帮忙在https://github.com/seata/seata/blob/develop/script/config-center/README.md 介绍下可交互脚本的使用。 |
好的 |
已完成,请帮忙再review一下 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…(apollo,consul,zk) #4332Realize configuration center upload configuration interactive script (apollo,consul,zk) #4332
Ⅰ. Describe what this PR did
Realize configuration center upload configuration interactive script (apollo,consul,zk) #4332
Ⅱ. Does this pull request fix one issue?
#4332
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews