optimize: commit/rollback retry timeout event #4391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Bughue please add change log and add global transaction status Desc in https://seata.io/zh-cn/docs/user/appendix/global-transaction-status.html |
|
funky-eyes
approved these changes
Feb 20, 2022
funky-eyes
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #4391 +/- ##
=============================================
+ Coverage 48.99% 49.02% +0.02%
- Complexity 3956 3961 +5
=============================================
Files 733 733
Lines 24988 24999 +11
Branches 3093 3093
=============================================
+ Hits 12244 12256 +12
+ Misses 11448 11446 -2
- Partials 1296 1297 +1
|
…op-retrytimeout # Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md
pengten
approved these changes
Feb 21, 2022
server/src/main/java/io/seata/server/session/SessionHelper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/session/SessionHelper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/session/SessionHelper.java
Outdated
Show resolved
Hide resolved
pengten
reviewed
Feb 23, 2022
server/src/main/java/io/seata/server/coordinator/DefaultCoordinator.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/session/SessionHelper.java
Outdated
Show resolved
Hide resolved
slievrly
reviewed
Feb 25, 2022
| eventBus.post(new GlobalTransactionEvent(globalSession.getTransactionId(), GlobalTransactionEvent.ROLE_TC, | ||
| globalSession.getTransactionName(), globalSession.getApplicationId(), globalSession.getTransactionServiceGroup(), | ||
| globalSession.getBeginTime(), null, globalSession.getStatus())); | ||
| SessionHelper.postTcSessionBeginEvent(globalSession); |
There was a problem hiding this comment.
postTcSessionBeginEvent is not appropriate here.
slievrly
reviewed
Feb 25, 2022
| globalSession.getApplicationId(), | ||
| globalSession.getTransactionServiceGroup(), globalSession.getBeginTime(), | ||
| null, globalSession.getStatus())); | ||
| SessionHelper.postTcSessionBeginEvent(globalSession); |
There was a problem hiding this comment.
postTcSessionBeginEvent is not appropriate here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
全局事务commit/rollback在MAX_ROLLBACK_RETRY_TIMEOUT或者MAX_COMMIT_RETRY_TIMEOUT之后发出eventBus，新增状态CommitRetryTimeout和RollbackRetryTimeout
Ⅱ. Does this pull request fix one issue?
#4387
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews