optimize: asynchronous tasks handle global transactions in parallel #4400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4400 +/- ##
==========================================
Coverage 48.76% 48.77%
Complexity 3968 3968
==========================================
Files 733 733
Lines 25182 25182
Branches 3131 3132 +1
==========================================
+ Hits 12280 12282 +2
Misses 11599 11599
+ Partials 1303 1301 -2
|
|
是否可以改造成线程池，并且可配置化会更好？ |
有道理，目前这样其实还是有点问题，因为这里的核心数其实是机器的核心数，导致业务线程池的默认核心数是50，大流量进来可能是50:4的差距，导致只要写大于删（二阶段补偿，或者异步提交）还是容易出现file/raft模式下内存被打满的情况 |
slievrly
reviewed
Mar 5, 2022
| @@ -226,7 +226,7 @@ public static boolean isTimeoutGlobalStatus(GlobalStatus status) { | |||
| * @since 1.5.0 | |||
| */ | |||
| public static void forEach(Collection<GlobalSession> sessions, GlobalSessionHandler handler) { | |||
| for (GlobalSession globalSession : sessions) { | |||
| sessions.parallelStream().forEach(globalSession -> { | |||
There was a problem hiding this comment.
It is best to define separate fork/join thread pools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
在多个全局事务的二阶段处理应该保持并行,提高效率
在file/raft模式中也可以尽快的释放内存空间
未来应该再结合分支事务的并行下发,以降低网络io的阻塞占用耗时
Ⅱ. Does this pull request fix one issue?
fixes #4399
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews