optimize: disable SAGA tests
#4403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4403 +/- ##
==========================================
Coverage 49.00% 49.00%
- Complexity 3952 3953 +1
==========================================
Files 733 733
Lines 24978 24978
Branches 3092 3091 -1
==========================================
Hits 12240 12240
Misses 11440 11440
Partials 1298 1298
|
wangliang181230
changed the title
SAGA testsSAGA tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
禁用SAGA单测：
SAGA的测试用例，避免失败的测试用例不会记录cost日志。SAGA单测：禁用三个非常耗时的单测、以及两个经常出错的单测，并标记FIXME。另外：
DefaultCoreTest偶发的ConcurrentModificationExceptionReview建议：
5个单测的代码变更行比较多，但实际上就是包装了一层日志打印，实际的测试代码并没有变更。建议在review界面勾选
Hide whitespace后再开始review