Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: file mode does not require lazy processing of sessions #4407

Merged
merged 3 commits into from
Feb 27, 2022

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Feb 26, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

目前的实现中,在同步二阶段时不会进行删除全局事务为了避免db和redis下残留branchsession和lock所以进行了默认2分10秒延迟删除,但是file下globalsession是有锁的,不会出现这种残留情况,也就无需延迟,仅需异步删除即可,file的内存是寸土寸金应尽快删除,所以需要通过storemode判断处理

Ⅱ. Does this pull request fix one issue?

fixes #4399

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 1.5.0 milestone Feb 26, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes changed the title optimize: file mode requires no delay in processing optimize: file mode does not require lazy processing of sessions Feb 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4407 (c41cac1) into develop (4622746) will decrease coverage by 0.00%.
The diff coverage is 16.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4407      +/-   ##
=============================================
- Coverage      48.76%   48.76%   -0.01%     
+ Complexity      3967     3965       -2     
=============================================
  Files            733      733              
  Lines          25182    25185       +3     
  Branches        3132     3135       +3     
=============================================
  Hits           12281    12281              
- Misses         11598    11602       +4     
+ Partials        1303     1302       -1     
Impacted Files Coverage Δ
...o/seata/server/coordinator/DefaultCoordinator.java 50.54% <16.66%> (-1.30%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 78.65% <0.00%> (ø)
...in/java/io/seata/server/session/SessionHelper.java 74.71% <0.00%> (+2.29%) ⬆️

@slievrly slievrly merged commit f86892d into apache:develop Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seata AT模式 file存储数据 持续高并发压力下导致频繁full gc
4 participants