-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix the invalid environment variable in container env #4408
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4408 +/- ##
=============================================
- Coverage 48.77% 48.75% -0.02%
- Complexity 3971 3977 +6
=============================================
Files 733 733
Lines 25185 25185
Branches 3134 3108 -26
=============================================
- Hits 12285 12280 -5
+ Misses 11598 11581 -17
- Partials 1302 1324 +22
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 请在changes文件夹中的两个1.5.0.md中进行登记pr作者和pr信息
已添加 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #4341
fixes #4392
fixes #4604
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews