Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the invalid environment variable in container env #4408

Merged
merged 5 commits into from
Feb 28, 2022

Conversation

liuqiufeng
Copy link
Contributor

@liuqiufeng liuqiufeng commented Feb 26, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #4341
fixes #4392
fixes #4604

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added first-time contributor first-time contributor module/server server module type: bug Category issues or prs related to bug. labels Feb 26, 2022
@funky-eyes funky-eyes added this to the 1.5.0 milestone Feb 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2022

Codecov Report

Merging #4408 (bb4d0f6) into develop (f86892d) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4408      +/-   ##
=============================================
- Coverage      48.77%   48.75%   -0.02%     
- Complexity      3971     3977       +6     
=============================================
  Files            733      733              
  Lines          25185    25185              
  Branches        3134     3108      -26     
=============================================
- Hits           12285    12280       -5     
+ Misses         11598    11581      -17     
- Partials        1302     1324      +22     
Impacted Files Coverage Δ
server/src/main/java/io/seata/server/Server.java 80.00% <ø> (+5.92%) ⬆️
...main/java/io/seata/server/env/ContainerHelper.java 87.50% <ø> (+75.00%) ⬆️
.../src/main/java/io/seata/server/env/PortHelper.java 40.74% <50.00%> (+3.00%) ⬆️
...src/main/java/io/seata/server/ParameterParser.java 66.07% <70.83%> (+18.24%) ⬆️
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0.00%> (-9.53%) ⬇️
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0.00%> (-7.41%) ⬇️
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0.00%> (-6.25%) ⬇️
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0.00%> (-6.25%) ⬇️
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0.00%> (-6.25%) ⬇️
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0.00%> (-5.27%) ⬇️
... and 21 more

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 请在changes文件夹中的两个1.5.0.md中进行登记pr作者和pr信息

@liuqiufeng
Copy link
Contributor Author

已添加

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix: fix the invalid environment variable in container env & remove container env judgment bugfix: fix the invalid environment variable in container env Feb 28, 2022
@slievrly slievrly merged commit 00f05eb into apache:develop Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment