Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add some copyright header for test classes #4409

Merged
merged 60 commits into from
Feb 28, 2022

Conversation

doubleDimple
Copy link
Contributor

@doubleDimple doubleDimple commented Feb 26, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

add open sources explain in some test classes not modify any logic After passing the checkStyle check add the open sources description

Ⅱ. Does this pull request fix one issue?

fixes #4358

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

doubleDimple and others added 30 commits January 3, 2022 15:01
# Conflicts:
#	core/src/main/java/io/seata/core/console/result/PageResult.java
#	server/src/main/java/io/seata/server/storage/SessionConverter.java
@doubleDimple doubleDimple changed the title [optimize] Add open sources explain optimize:Add open sources explain Feb 26, 2022
@doubleDimple doubleDimple changed the title optimize:Add open sources explain optimize:Add open sources explain Feb 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2022

Codecov Report

Merging #4409 (114802f) into develop (f86892d) will increase coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4409      +/-   ##
=============================================
+ Coverage      48.77%   48.85%   +0.07%     
- Complexity      3971     3977       +6     
=============================================
  Files            733      733              
  Lines          25185    25186       +1     
  Branches        3134     3140       +6     
=============================================
+ Hits           12285    12304      +19     
+ Misses         11598    11581      -17     
+ Partials        1302     1301       -1     
Impacted Files Coverage Δ
...seata/discovery/registry/FileRegistryProvider.java 0.00% <ø> (ø)
server/src/main/java/io/seata/server/Server.java 80.00% <ø> (+5.92%) ⬆️
...ava/io/seata/server/ServerApplicationListener.java 52.38% <ø> (ø)
...main/java/io/seata/server/env/ContainerHelper.java 87.50% <ø> (+75.00%) ⬆️
...a/spring/kt/support/TransactionCoroutineContext.kt 0.00% <ø> (ø)
.../java/io/seata/spring/kt/support/TransactionDsl.kt 0.00% <ø> (ø)
.../src/main/java/io/seata/server/env/PortHelper.java 40.74% <50.00%> (+3.00%) ⬆️
...src/main/java/io/seata/server/ParameterParser.java 66.07% <70.83%> (+18.24%) ⬆️
.../java/io/seata/server/coordinator/DefaultCore.java 48.12% <0.00%> (-2.50%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 78.65% <0.00%> (-1.19%) ⬇️
... and 7 more

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pr登记做一下,changes文件夹中的两个1.5.0.md

@funky-eyes funky-eyes changed the title optimize:Add open sources explain optimize: add open sources explain Feb 26, 2022
@funky-eyes funky-eyes added this to the 1.5.0 milestone Feb 26, 2022
changes/1.5.0.md Outdated Show resolved Hide resolved
@slievrly slievrly changed the title optimize: add open sources explain optimize: add some copyright header for test classes Feb 28, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 505797c into apache:develop Feb 28, 2022
@doubleDimple doubleDimple deleted the add_openSources_ins_4358 branch February 28, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some test classes do not have open source instructions
4 participants