-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: add some copyright header for test classes #4409
Merged
slievrly
merged 60 commits into
apache:develop
from
doubleDimple:add_openSources_ins_4358
Feb 28, 2022
Merged
optimize: add some copyright header for test classes #4409
slievrly
merged 60 commits into
apache:develop
from
doubleDimple:add_openSources_ins_4358
Feb 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/main/java/io/seata/core/console/result/PageResult.java # server/src/main/java/io/seata/server/storage/SessionConverter.java
# Conflicts: # server/src/main/java/io/seata/server/session/SessionCondition.java # server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java
Codecov Report
@@ Coverage Diff @@
## develop #4409 +/- ##
=============================================
+ Coverage 48.77% 48.85% +0.07%
- Complexity 3971 3977 +6
=============================================
Files 733 733
Lines 25185 25186 +1
Branches 3134 3140 +6
=============================================
+ Hits 12285 12304 +19
+ Misses 11598 11581 -17
+ Partials 1302 1301 -1
|
funky-eyes
approved these changes
Feb 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pr登记做一下,changes文件夹中的两个1.5.0.md
…dd_openSources_ins_4358
slievrly
reviewed
Feb 27, 2022
slievrly
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
add open sources explain in some test classes not modify any logic After passing the checkStyle check add the open sources description
Ⅱ. Does this pull request fix one issue?
fixes #4358
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews