Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: limit redis mode all sessions #4431

Merged
merged 64 commits into from
Mar 5, 2022
Merged

optimize: limit redis mode all sessions #4431

merged 64 commits into from
Mar 5, 2022

Conversation

doubleDimple
Copy link
Contributor

@doubleDimple doubleDimple commented Mar 3, 2022 •
edited

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

limit the number of queries in Redis storage mode

Ⅱ. Does this pull request fix one issue?

fixes #4429

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

doubleDimple and others added 30 commits January 3, 2022 15:01
@doubleDimple
通用分页计算
dd38eae
@doubleDimple
redis query globalsession(if request param isnull) commit
1d2bce2
@doubleDimple
redis query globalsession(if request param isnull) commit
7dde6f4
@doubleDimple
redis query globalsession third commit
6c2d330
@doubleDimple
redis query globalsession third commit
9c41301
@doubleDimple
redis query globalsession third commit
a772160
@doubleDimple
Merge branch 'develop' into develop
806f812
@doubleDimple
redis query globalsession five commit
edac1e4
@doubleDimple
Merge remote-tracking branch 'origin/develop' into develop
143cf18
add test case code
ff833d1
@doubleDimple
Merge branch 'seata:develop' into develop
85b66ec
@doubleDimple
add redis query globalSession by page test code
1429677
@doubleDimple
add redis query globalSession by page test code
c6970e6
@doubleDimple
add redis query globalSession by page test code
75e2b68
@doubleDimple
Merge branch 'seata:develop' into develop
02fa91b
@doubleDimple
add test case code
3c2c268
@doubleDimple
add redis mode query globalLock code submit
ce9886a
@doubleDimple
add globalSessionService test code
0572e16
@doubleDimple
Merge branch 'seata:develop' into develop
dbb4376
@doubleDimple
add author
dcceeff
@doubleDimple
Merge remote-tracking branch 'origin/develop' into develop
19bf5a6
@doubleDimple
qery redis globalSession and globalLock optimize
db243ec
@doubleDimple
add author
5c68d2c
@doubleDimple
update test case
bc04c40
@doubleDimple
Merge branch 'seata:develop' into develop
2b7edb3
@doubleDimple
code format
db0326c
@doubleDimple
Merge branch 'develop' of github.com:seata/seata into develop
ee798d4 
# Conflicts:
#	core/src/main/java/io/seata/core/console/result/PageResult.java
#	server/src/main/java/io/seata/server/storage/SessionConverter.java
@doubleDimple
update changes.md
348a0a2
@doubleDimple
optimize
c4993fc
@doubleDimple
Merge branch 'develop' into develop
4328c07
@doubleDimple doubleDimple changed the title Limit redis mode all sessions optimize:Limit redis mode all sessions Mar 3, 2022
@doubleDimple doubleDimple changed the title optimize:Limit redis mode all sessions [WIP]optimize:Limit redis mode all sessions Mar 3, 2022
@doubleDimple doubleDimple changed the title [WIP]optimize:Limit redis mode all sessions [WIP]optimize:limit redis mode all sessions Mar 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022 •
edited

Codecov Report

Merging #4431 (7387dda) into develop (73532fa) will decrease coverage by 0.07%.
The diff coverage is 90.90%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4431      +/-   ##
=============================================
- Coverage      48.51%   48.44%   -0.08%     
+ Complexity      3965     3963       -2     
=============================================
  Files            733      733              
  Lines          25154    25163       +9     
  Branches        3084     3086       +2     
=============================================
- Hits           12203    12189      -14     
- Misses         11635    11659      +24     
+ Partials        1316     1315       -1
Impacted Files Coverage Δ
...ava/io/seata/core/constants/RedisKeyConstants.java 0.00% <ø> (ø)
...rage/db/store/DataBaseTransactionStoreManager.java 59.03% <ø> (ø)
...rage/redis/store/RedisTransactionStoreManager.java 61.16% <90.90%> (+1.83%) ⬆️
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (-15.39%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 45.09% <0.00%> (-5.82%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 79.83% <0.00%> (-0.41%) ⬇️

@doubleDimple doubleDimple changed the title [WIP]optimize:limit redis mode all sessions optimize:limit redis mode all sessions Mar 4, 2022
@funky-eyes funky-eyes changed the title optimize:limit redis mode all sessions optimize: limit redis mode all sessions Mar 4, 2022
funky-eyes
funky-eyes approved these changes Mar 5, 2022
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone Mar 5, 2022
caohdgege
caohdgege approved these changes Mar 5, 2022
View reviewed changes
Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caohdgege caohdgege merged commit 6fab0e8 into apache:develop Mar 5, 2022
@doubleDimple doubleDimple deleted the limit_redisMode_allSessions_4429 branch March 5, 2022 15:49
slievrly
slievrly reviewed Mar 5, 2022
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it conflict with the GlobalSessionParam pageNum parameter?

@slievrly
Copy link
Member

slievrly commented Mar 5, 2022

Does it conflict with the GlobalSessionParam pageNum parameter?

GlobalSessionParam calls readSession with the xid conditional argument, so there is no problem.

liuqiufeng pushed a commit to liuqiufeng/seata that referenced this pull request Mar 6, 2022
@doubleDimple @liuqiufeng
optimize: limit redis mode all sessions (apache#4431)
68e58e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly left review comments

@funky-eyes funky-eyes funky-eyes approved these changes

@caohdgege caohdgege caohdgege approved these changes

Assignees
No one assigned
Labels
module/server server module TC/store store mode type: optimize
Projects
None yet
Milestone
1.5.0 (1.5.1)
Development

Successfully merging this pull request may close these issues.

limit the number of queries in Redis storage mode
5 participants
@doubleDimple @codecov-commenter @slievrly @funky-eyes @caohdgege