-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fixed the inability to get some remote configurations #4432
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4432 +/- ##
=============================================
+ Coverage 48.32% 48.36% +0.04%
+ Complexity 3970 3960 -10
=============================================
Files 734 734
Lines 25300 25330 +30
Branches 3109 3115 +6
=============================================
+ Hits 12225 12251 +26
- Misses 11750 11756 +6
+ Partials 1325 1323 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
该bug会导致nacos等配置中心配置了store.mode=db,但是本地的openapi的实现类却用的file,除非在本地properties再配置上store.mode=db,否则不生效
而如果要通过nacos,需要先实例化fileconfiguration,而fileconfiguration会被springbootcglib代理,原先的实现用的是applicationcontext在bean加载后去findbean,而GenericApplicationListener的加载是非常早的,所以导致了configuration无法使用,特此需要改造使用ConfigurableEnvironment去读取配置,并转换
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews