Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: seata-server remove cms parameters #4434

Merged
merged 46 commits into from Dec 16, 2022

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Mar 4, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

byte-buddy替换cglib

Ⅱ. Does this pull request fix one issue?

fixes #4123
fixes #4663
fixes #4703
fixes #4752
fixes #4821

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 2.0.0 milestone Mar 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2022

Codecov Report

Merging #4434 (c5ae741) into develop (bf99018) will decrease coverage by 0.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4434      +/-   ##
=============================================
- Coverage      48.95%   48.53%   -0.43%     
+ Complexity      4168     4134      -34     
=============================================
  Files            741      741              
  Lines          26521    26521              
  Branches        3294     3294              
=============================================
- Hits           12984    12871     -113     
- Misses         12129    12255     +126     
+ Partials        1408     1395      -13     
Impacted Files Coverage Δ
.../main/java/io/seata/config/ConfigurationCache.java 74.07% <100.00%> (ø)
...ava/io/seata/server/metrics/MetricsSubscriber.java 14.78% <0.00%> (-64.35%) ⬇️
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (-15.39%) ⬇️
...erver/storage/file/session/FileSessionManager.java 48.40% <0.00%> (-5.74%) ⬇️
...ver/storage/redis/session/RedisSessionManager.java 45.61% <0.00%> (-5.27%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 44.26% <0.00%> (-4.51%) ⬇️
.../java/io/seata/server/coordinator/DefaultCore.java 44.97% <0.00%> (-2.96%) ⬇️
...rage/redis/store/RedisTransactionStoreManager.java 72.06% <0.00%> (-2.62%) ⬇️
...o/seata/server/session/AbstractSessionManager.java 58.20% <0.00%> (-1.50%) ⬇️
...in/java/io/seata/server/session/BranchSession.java 79.13% <0.00%> (-1.44%) ⬇️
... and 8 more

@funky-eyes funky-eyes requested review from wangliang181230 and slievrly and removed request for wangliang181230 March 4, 2022 14:24
@funky-eyes funky-eyes changed the title feature: seata-server support jdk17 feature: seata support jdk17 Mar 4, 2022
@funky-eyes funky-eyes added apm/skywalking module/config config module module/server server module type: feature Category issues or prs related to feature request. and removed apm/skywalking labels Mar 5, 2022
@funky-eyes funky-eyes mentioned this pull request Oct 14, 2022
@luojunjiess
Copy link

image

so,seata still not support jdk17?

@funky-eyes
Copy link
Contributor Author

funky-eyes commented Oct 24, 2022

@luojunjiess

这个pr就是支持jdk17的

@DreamSaddle
Copy link

@luojunjiess

这个pr就是支持jdk17的

请问什么时候能合并此 PR 发布新版本以支持 JDK17 呢?
谢谢!

@wangliang181230
Copy link
Contributor

wangliang181230 commented Nov 28, 2022

这个PR应该是server端的启动脚本,兼容JDK17。
client之前就已经兼容了的。当然有部分第三方组件不兼容JDK17,选用不兼容的组件时,在JDK17下也是无法使用的。

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ xingfudeshi
❌ wangliang181230
❌ a364176773
You have signed the CLA already but the status is still pending? Let us recheck it.

@funky-eyes funky-eyes changed the title feature: seata support jdk17 optimize: seata-server remove cms parameters Dec 15, 2022
@funky-eyes funky-eyes modified the milestones: 2.0.0, 1.6.1 Dec 15, 2022
@funky-eyes funky-eyes added type: optimize and removed type: feature Category issues or prs related to feature request. module/config config module labels Dec 15, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly modified the milestones: 1.6.1, 1.6.0 Dec 16, 2022
@slievrly slievrly merged commit 851e35f into apache:develop Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants