bugfix: fix GlobalSession cannot be cleared normally when delayed deletion is enabled #4438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4438 +/- ##
=============================================
- Coverage 48.34% 48.34% -0.01%
+ Complexity 3971 3970 -1
=============================================
Files 734 734
Lines 25277 25275 -2
Branches 3105 3105
=============================================
- Hits 12220 12218 -2
+ Misses 11739 11737 -2
- Partials 1318 1320 +2
|
funky-eyes
added
module/server
funky-eyes
reviewed
Mar 6, 2022
funky-eyes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alSession
Ⅰ. Describe what this PR did
GlobalSession在延迟删除的情况下，由于提前设置了Rollbacked状态导致定时任务无法即时处理。目前放弃提前设置状态，改为由DefaultCore#doGlobalRollback的执行结果来确认是否返回Rollbacked状态
In the case of delayed deletion of GlobalSession, the scheduled task cannot be processed immediately because the Rollbacked state is set in advance. At present, the advance setting state is abandoned, and the execution result of DefaultCore#doGlobalRollback is used to confirm whether to return the Rollbacked state.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews