Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the change log of 'service.disableGlobalTransaction' config #4452

Merged
merged 7 commits into from
Mar 9, 2022

Conversation

pengten
Copy link
Contributor

@pengten pengten commented Mar 9, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

修复一个日志打印错误的问题

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #4452 (988c51f) into develop (1ddde40) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4452   +/-   ##
==========================================
  Coverage      48.36%   48.36%           
- Complexity      3960     3961    +1     
==========================================
  Files            734      734           
  Lines          25330    25331    +1     
  Branches        3115     3115           
==========================================
+ Hits           12251    12252    +1     
  Misses         11756    11756           
  Partials        1323     1323           
Impacted Files Coverage Δ
...ta/spring/annotation/GlobalTransactionScanner.java 30.65% <0.00%> (-0.16%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 50.18% <0.00%> (+0.36%) ⬆️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone Mar 9, 2022
@funky-eyes funky-eyes added module/spring spring module type: bug Category issues or prs related to bug. labels Mar 9, 2022
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit ea0607b into apache:develop Mar 9, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/spring spring module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants