Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix the README.md of metrices module #4458

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

pengten
Copy link
Contributor

@pengten pengten commented Mar 11, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

修复 metrices 模块 README.md 的配置遗漏问题

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.5.0 milestone Mar 12, 2022
@funky-eyes funky-eyes changed the title bugfix: fix the README.md of metrices module docs: fix the README.md of metrices module Mar 12, 2022
Copy link
Contributor

@objcoding objcoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@objcoding objcoding merged commit 8164311 into apache:develop Mar 12, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Bughue pushed a commit to Bughue/seata that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants