bugfix:fix the failure to obtain before image and after image on oracle and pgsql of the develop branch #4459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r databases except mysql database
caohdgege
reviewed
Mar 12, 2022
| } | ||
|
|
||
| @Override | ||
| public Set<String> keySet() { | ||
| return targetMap.keySet(); | ||
| return lowerKeyToOriginMap.keySet(); |
There was a problem hiding this comment.
这里用values的话，是不是就不需要下面的内容了？？
There was a problem hiding this comment.
mysql数据库还是需要被转成小写的key,其他数据库才会去拿原始的key,所以这里优先返回小写的key
|
你这个是bugfix，去录个对应的issue然后再这边关联一下 |
已关联 |
funky-eyes
added
first-time contributor
funky-eyes
reviewed
Mar 12, 2022
changes/1.5.0.md
Outdated
| @@ -104,6 +104,7 @@ Seata 是一款开源的分布式事务解决方案，提供高性能和简单 | |||
| - [[#4438](https://github.com/seata/seata/pull/4438)] 修复develop版本file模式下GlobalSession在延迟删除的情况下无法被正常删除的问题 | |||
| - [[#4432](https://github.com/seata/seata/pull/4432)] 修复develop版本下ServerApplicationListener无法读取配置中心配置的问题 | |||
| - [[#4452](https://github.com/seata/seata/pull/4452)] 修复'service.disableGlobalTransaction'配置的日志输出错误 | |||
| - [[#4459](https://github.com/seata/seata/pull/4459)] 修复除mysql外其他数据库生成前后镜像失败的问题 | |||
There was a problem hiding this comment.
这个问题是否只有develop分支如此?如果是的话需要特别标出问题所在的版本,否者会吓到正常使用的用户
There was a problem hiding this comment.
只有develop分支才有这个问题，而且是#4222这个commit之后才会有
There was a problem hiding this comment.
只有develop分支才有这个问题，而且是#4222这个commit之后才会有
所以你这块应该是修复develop版本除mysql外其他数据库生成前后镜像失败的问题
There was a problem hiding this comment.
只有develop分支才有这个问题，而且是#4222这个commit之后才会有
这块要改一下，否者会吓到用1.4.2的用户
funky-eyes
reviewed
Mar 12, 2022
| if (isMysqlSeries(dbType)) { | ||
| return addEscape(column, dbType, ColumnUtils.Escape.MYSQL); | ||
| } | ||
| if (allColumns instanceof LowerCaseLinkHashMap) { |
| @@ -33,6 +36,7 @@ | |||
|
|
|||
| private static final String DOT = "."; | |||
|
|
|||
|
|
|||
funky-eyes
approved these changes
Mar 15, 2022
changes/1.5.0.md
Outdated
| @@ -104,6 +104,7 @@ Seata 是一款开源的分布式事务解决方案，提供高性能和简单 | |||
| - [[#4438](https://github.com/seata/seata/pull/4438)] 修复develop版本file模式下GlobalSession在延迟删除的情况下无法被正常删除的问题 | |||
| - [[#4432](https://github.com/seata/seata/pull/4432)] 修复develop版本下ServerApplicationListener无法读取配置中心配置的问题 | |||
| - [[#4452](https://github.com/seata/seata/pull/4452)] 修复'service.disableGlobalTransaction'配置的日志输出错误 | |||
| - [[#4459](https://github.com/seata/seata/pull/4459)] 修复除mysql外其他数据库生成前后镜像失败的问题 | |||
There was a problem hiding this comment.
只有develop分支才有这个问题，而且是#4222这个commit之后才会有
这块要改一下，否者会吓到用1.4.2的用户
tuwenlin
changed the title
tuwenlin
changed the title
tuwenlin
changed the title
tuwenlin
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #4459 +/- ##
=============================================
+ Coverage 48.96% 49.30% +0.34%
- Complexity 4030 4046 +16
=============================================
Files 731 731
Lines 25323 25330 +7
Branches 3137 3136 -1
=============================================
+ Hits 12399 12490 +91
+ Misses 11596 11517 -79
+ Partials 1328 1323 -5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r databases except mysql database
Ⅰ. Describe what this PR did
只有develop版本#4222 pr之后才有此问题
修复除了mysql数据库之外的其他数据库生成前后镜像因大小写问题失败的问题
fixes #4460
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews