Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize client version transfer. #4465

Merged
merged 5 commits into from
Mar 16, 2022

Conversation

objcoding
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

#4196

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@objcoding objcoding added the module/core core module label Mar 13, 2022
@objcoding objcoding added this to the 1.5.0 milestone Mar 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4465 (f691770) into develop (90be080) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4465      +/-   ##
=============================================
- Coverage      48.86%   48.85%   -0.02%     
- Complexity      4006     4007       +1     
=============================================
  Files            730      730              
  Lines          25272    25270       -2     
  Branches        3126     3126              
=============================================
- Hits           12350    12346       -4     
- Misses         11595    11601       +6     
+ Partials        1327     1323       -4     
Impacted Files Coverage Δ
...io/seata/core/rpc/netty/AbstractNettyRemoting.java 14.28% <ø> (+0.09%) ⬆️
...rpc/processor/server/ServerOnRequestProcessor.java 0.00% <0.00%> (ø)
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (-15.39%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 44.76% <0.00%> (+0.72%) ⬆️
.../java/io/seata/spring/util/TCCBeanParserUtils.java 32.25% <0.00%> (+1.61%) ⬆️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 80dd842 into develop Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/core core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants